test_volume_get_all_filters_limit incorrectly asserts certain metadata ordering

[Alex Meade]

cinder.tests.test_db_api.DBAPIVolumeTestCase.test_volume_get_all_filters_limit

This test indirectly asserts that the metadata on a volume is returned in a certain order. This is incorrect because python dictionaries to not maintain ordering. This causes spuratic unit test failures with this error:

http://paste.openstack.org/show/73692/

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/82177
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=4cc2366623743393f89a198581fcb69dc04d31cd
Submitter: Jenkins
Branch: master

commit 4cc2366623743393f89a198581fcb69dc04d31cd
Author: Juan Manuel Olle <email address hidden>
Date: Fri Mar 21 16:46:03 2014 -0300

    Correct metadata ordering issue in tests

    Some test including test_volume_get_all_filters
    fails randomly because metadata is in a dict and
    the items order is undefined.
    The test comparison was changed to avoid unexpected
    test results.

    Change-Id: Ibb24d21cd05aa1eefb45b61c63de067b34fb1013
    Closes-Bug: #1293792

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/91039

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/91039
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=59fe59ebfc93a9354aa4598a39c7132cc38938fe
Submitter: Jenkins
Branch: stable/icehouse

commit 59fe59ebfc93a9354aa4598a39c7132cc38938fe
Author: Juan Manuel Olle <email address hidden>
Date: Fri Mar 21 16:46:03 2014 -0300

    Correct metadata ordering issue in tests

    Some test including test_volume_get_all_filters
    fails randomly because metadata is in a dict and
    the items order is undefined.
    The test comparison was changed to avoid unexpected
    test results.

    Change-Id: Ibb24d21cd05aa1eefb45b61c63de067b34fb1013
    Closes-Bug: #1293792
    (cherry picked from commit 4cc2366623743393f89a198581fcb69dc04d31cd)