Cinder's upload-to-image function can't create protected & public images

[Yogev Rabl]

Description of problem:
The Cinder's upload-to-image feature can upload a volume to Glance as an image. The Glance's image creation has options that are relevant, but missing from the upload-to-image:
--store <STORE>
--is-public {True,False}
--is-protected {True,False}

Version-Release number of selected component (if applicable):
python-cinderclient-1.0.7-2.el6ost.noarch
python-cinder-2013.2.2-1.el6ost.noarch
openstack-cinder-2013.2.2-1.el6ost.noarch

How reproducible:
100%

Steps to Reproduce:
1. Create a volume
2. Upload the volume to the Glance as a protected & public image.
 # cinder upload-to-image <volume uid> <image name> --is-protected True --is-public True

Actual results:
The flags is-protected & is-public are not available.

Expected results:
The upload-to-image should be able to create a protected & public images.

[John Griffith (john-griffith)]

Might be a handy feature, although glance image-update works for this purpose as well.

[Mike Perez (thingee)]

Glance v1 has this set in the header it seems:

http://docs.openstack.org/api/openstack-image-service/1.1/content/adding-image-metadata-in-http-headers.html

While glance v2 has this as a parameter:

http://api.openstack.org/api-ref-image.html#image-v2

Both should be supported.

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/89769

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/89770

[OpenStack Infra (hudson-openstack)]

Change abandoned by Duncan Thomas (<email address hidden>) on branch: master
Review: https://review.openstack.org/89769
Reason: Abandoning change: No update for more than 14 days

[OpenStack Infra (hudson-openstack)]

Change abandoned by Eric Harney (<email address hidden>) on branch: master
Review: https://review.openstack.org/89770
Reason: Needs updating, appears to be abandoned.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/152460

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/152475

[OpenStack Infra (hudson-openstack)]

Change abandoned by Mike Perez (<email address hidden>) on branch: master
Review: https://review.openstack.org/152475
Reason: Over a month with no update.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/230617

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/230622

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean McGinnis (<email address hidden>) on branch: master
Review: https://review.openstack.org/152460
Reason: This review is > 8 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/230617
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f8ce884002817bb76c68616314dc2dc5cedb61d6
Submitter: Jenkins
Branch: master

commit f8ce884002817bb76c68616314dc2dc5cedb61d6
Author: Nathaniel Potter <email address hidden>
Date: Fri Oct 2 14:07:03 2015 -0500

    Added more options while uploading volume as image

    Added support for is_public/visibility, and protected
    while uploading volume as image to image service.
    is_public/visibility is used to make the image publicly accessible
    and protected is used to prevent the image from being deleted.

    DocImpact
    APIImpact

    Change-Id: I6e6b2276af22b7809ea88289427c6873211b3faf
    Closes-Bug: #1288131

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/230622
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=7590fe4b7d8a0b75b3257f6676c773052c8019c0
Submitter: Jenkins
Branch: master

commit 7590fe4b7d8a0b75b3257f6676c773052c8019c0
Author: Nathaniel Potter <email address hidden>
Date: Fri Oct 2 14:37:28 2015 -0500

    Add options when uploading images to Glance

    Added --visibility and --protected options
    when uploading volumes to the image service.

    DocImpact

    Change-Id: Ie639179c5bbbaca4de62b42b368830afcfd8f7ac
    Closes-Bug: #1288131
    Depends-On: I6e6b2276af22b7809ea88289427c6873211b3faf
    Signed-off-by: Nathaniel Potter <email address hidden>

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/python-cinderclient 1.7.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/cinder 9.0.0.0b1 development milestone.