Add snapshot list when failing to delete volume because of snapshot

[Dafna Ron]

when we fail to delete a volume because of snapshot dependency, error message should print the snapshot ID:

root@opens-vdsb ~(keystone_admin)]# cinder list
+--------------------------------------+-----------+--------------+------+-------------+----------+-------------+
| ID | Status | Display Name | Size | Volume Type | Bootable | Attached to |
+--------------------------------------+-----------+--------------+------+-------------+----------+-------------+
| 7b7acdc1-c1fe-4654-93f9-7c3afc03b395 | available | test | 10 | None | false | |
| fece4bd4-0a96-4bd3-8661-101dcbce8e28 | available | bla | 10 | None | false | |
+--------------------------------------+-----------+--------------+------+-------------+----------+-------------+
[root@opens-vdsb ~(keystone_admin)]# cinder delete 7b7acdc1-c1fe-4654-93f9-7c3afc03b395
ERROR: Invalid volume: Volume still has 2 dependent snapshots

[sandeep mane (sandeep-mane)]

done with code changes, facing some issues in git review, not able to connect review.openstack.org

i'll mark for review once done with commit & review step

Thanks,
Sandeep

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/79237

[Mike Perez (thingee)]

Sandeep, thanks for this! I believe this is more appropriate to be a blueprint. https://wiki.openstack.org/wiki/Blueprints

[Huang Zhiteng (zhiteng-huang)]

The review https://review.openstack.org/#/c/79237/ is still in progress. Why did you mark this bug as Fix Committed?

[sandeep mane (sandeep-mane)]

Hi,

I have committed code as well as testcase in tempest
please let me know, what are pending task now

--Thanks,
Sandeep

[sandeep mane (sandeep-mane)]

also updated code,testcase with review comment

--sandeep

[Huang Zhiteng (zhiteng-huang)]

Code change is only considered 'committed' when it is merged into master branch. 'In Progress' is proper state for the bug. https://review.openstack.org/#/c/79237/ is still in review and far from being merged and I did not see any test case in it and the last negative review opinion hasn't been addressed yet.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Duncan Thomas (<email address hidden>) on branch: master
Review: https://review.openstack.org/79237
Reason: Abandoning change: No update for more than 14 days