QoS specs update return value

Bug #1272365 reported by Eric Harney
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Medium
Avishay Traeger

Bug Description

In db/api.py, qos_specs_update calls "IMPL.qos_specs_update()" instead of "return IMPL.qos_specs_update()".

This generates a pylint lintstack error:
["Assigning to function call which doesn't return", "res = db.qos_specs_update(context, qos_specs_id, specs)"]

This doesn't look right -- I assume the result should be returned from db.qos_specs_update.

Tags: db
Changed in cinder:
status: New → Confirmed
tags: added: db
Changed in cinder:
assignee: nobody → Avishay Traeger (avishay-il)
importance: Undecided → High
importance: High → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/74997

Changed in cinder:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/74997
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=b1e7d0ad220d869323754683dbb447f6821ef705
Submitter: Jenkins
Branch: master

commit b1e7d0ad220d869323754683dbb447f6821ef705
Author: Avishay Traeger <email address hidden>
Date: Thu Feb 20 13:22:37 2014 +0200

    Ensure return for db api functions

    Functions in db/api.py should return whatever the implementation of
    those functions return. This is important for qos_specs_update which
    returns something for the sqlalchemy implementation, but for others as
    well for future implementations.

    Added 'return' for functions that were missing it.

    Change-Id: I384b1cf915b2d2238fd75d23b17558cae2cf9f50
    Closes-Bug: #1272365

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → icehouse-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.