NFS/GlusterFS drivers should validate format of configured shares

Bug #1267253 reported by Eric Harney on 2014-01-08
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Medium
Eric Harney
Havana
Undecided
Unassigned

Bug Description

The NFS and GlusterFS drivers accept shares that aren't a valid format (i.e. aren't something that Cinder/Nova can mount). It would be more user-friendly to catch these up front and log a message rather than trying to mount them and failing.

Fix proposed to branch: master
Review: https://review.openstack.org/65540

Changed in cinder:
status: New → In Progress
Changed in cinder:
importance: Undecided → Medium
milestone: none → icehouse-2

Reviewed: https://review.openstack.org/65540
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=21ebf2898e2f5fc8127b7a3bdc9743c49933f952
Submitter: Jenkins
Branch: master

commit 21ebf2898e2f5fc8127b7a3bdc9743c49933f952
Author: Eric Harney <email address hidden>
Date: Mon Dec 9 15:34:39 2013 -0500

    NFS/GlusterFS: Skip incorrectly formatted shares

    Shares should always be of the form address:/volume. If they are
    not (i.e., are missing the '/'), then skip them and issue a warning
    message. This will prevent us from sending incorrect connection_info
    dicts to Nova.

    Closes-Bug: #1267253

    Change-Id: Ic40cd0cdc862b44b0a7d3e5b1d7c4fee8ea1b28d

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2014-01-22
Changed in cinder:
status: Fix Committed → Fix Released

Reviewed: https://review.openstack.org/65936
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=66873311e510aea5c349e64f7f9e9e94a662a453
Submitter: Jenkins
Branch: stable/havana

commit 66873311e510aea5c349e64f7f9e9e94a662a453
Author: Eric Harney <email address hidden>
Date: Mon Dec 9 15:34:39 2013 -0500

    NFS/GlusterFS: Skip incorrectly formatted shares

    Shares should always be of the form address:/volume. If they are
    not (i.e., are missing the '/'), then skip them and issue a warning
    message. This will prevent us from sending incorrect connection_info
    dicts to Nova.

    Closes-Bug: #1267253

    Change-Id: Ic40cd0cdc862b44b0a7d3e5b1d7c4fee8ea1b28d
    (cherry picked from commit 21ebf2898e2f5fc8127b7a3bdc9743c49933f952)

tags: added: in-stable-havana
Thierry Carrez (ttx) on 2014-04-17
Changed in cinder:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers