GlusterFS: Use correct base argument when deleting attached snaps

Bug #1262880 reported by Eric Harney on 2013-12-19
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Cinder
High
Eric Harney
Havana
High
Eric Harney

Bug Description

The base= field is not using the correct value when a libvirt snapshot_delete is issued on the Nova side -- pass correct values for "file_to_merge" in the delete_info dict depending on whether or not other snapshots exist.

This fixes an issue where attached snapshot deletion results in an inconsistent qcow2 chain.

Eric Harney (eharney) on 2013-12-19
description: updated
description: updated

Fix proposed to branch: master
Review: https://review.openstack.org/63223

Changed in cinder:
status: New → In Progress
Mike Perez (thingee) on 2013-12-24
tags: added: drivers glusterfs
Eric Harney (eharney) on 2013-12-30
Changed in cinder:
milestone: none → icehouse-2

Reviewed: https://review.openstack.org/63223
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=186221779a92002ff9fa13c254710c0abb3803be
Submitter: Jenkins
Branch: master

commit 186221779a92002ff9fa13c254710c0abb3803be
Author: Eric Harney <email address hidden>
Date: Wed Dec 18 19:11:44 2013 -0500

    GlusterFS: Use correct base argument when deleting attached snaps

    When deleting the most recent snapshot, the 'file_to_merge' field
    which translates into the base= field for libvirt's blockRebase
    call in Nova must be set depending on whether other snapshots exist.

    If there are no other snapshots, base = None, which results in
    libvirt clearing the qcow2 backing file pointer for the active
    disk image.

    If there are other snapshots, pass the parent of the file being
    deleted as the new base file. The snapshot info pointer for the
    prior base file must also be updated in this case.

    Closes-Bug: #1262880
    Change-Id: If7bc8259b031d0406346caafb8f688e65a38dba6

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2014-01-22
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2014-04-17
Changed in cinder:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers