Ensure ThinLVM LV is active when cloning from volume

Bug #1260786 reported by Eric Harney on 2013-12-13
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Medium
Eric Harney
Havana
Medium
Eric Harney

Bug Description

Follow up to bug 1252423. Previous change activated the source snapshot LV when cloning from snapshot, but not when cloning from volume.

The same change needs to be made in the LVM driver's clone from volume path.

Otherwise cloning from volume for ThinLVM on platforms that do not automatically enable Thin snapshot LVs will fail.

Eric Harney (eharney) on 2013-12-13
Changed in cinder:
importance: Undecided → Medium

Fix proposed to branch: master
Review: https://review.openstack.org/62035

Changed in cinder:
status: New → In Progress
Eric Harney (eharney) on 2014-01-14
Changed in cinder:
milestone: none → icehouse-2
Thierry Carrez (ttx) on 2014-01-22
Changed in cinder:
milestone: icehouse-2 → icehouse-3

Reviewed: https://review.openstack.org/62035
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=673057320929d33095c998d477c2537567ccf74b
Submitter: Jenkins
Branch: master

commit 673057320929d33095c998d477c2537567ccf74b
Author: Eric Harney <email address hidden>
Date: Fri Dec 13 11:18:56 2013 -0500

    LVM: Activate source snap LV when cloning from volume

    Similar to the change made in:
    01a2199 LVM: Activate source LV before cloning from it

    Previous change only fixed this issue for clone-from-snapshot.

    This activates the source snapshot LV when cloning from volume
    as well, fixing the problem where cloning fails due to inability
    to open the source LV device.

    Change-Id: If48be8516fd71738cb83a91683c33d02f227b9d6
    Related-Bug: 1252423
    Closes-Bug: 1260786

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2014-03-05
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2014-04-17
Changed in cinder:
milestone: icehouse-3 → 2014.1
Alan Pevec (apevec) on 2014-09-18
tags: removed: havana-backport-potential

Reviewed: https://review.openstack.org/70056
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=797bbe29abd9095b752fb2bb31cb76454b02ff97
Submitter: Jenkins
Branch: stable/havana

commit 797bbe29abd9095b752fb2bb31cb76454b02ff97
Author: Eric Harney <email address hidden>
Date: Fri Dec 13 11:18:56 2013 -0500

    LVM: Activate source snap LV when cloning from volume

    Similar to the change made in:
    01a2199 LVM: Activate source LV before cloning from it

    Previous change only fixed this issue for clone-from-snapshot.

    This activates the source snapshot LV when cloning from volume
    as well, fixing the problem where cloning fails due to inability
    to open the source LV device.

    Related-Bug: 1252423
    Closes-Bug: 1260786

    (cherry picked from commit 673057320929d33095c998d477c2537567ccf74b)

    Change-Id: If48be8516fd71738cb83a91683c33d02f227b9d6

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers