cinder test_migrations fails for mysql

Bug #1260126 reported by Jay Bryant on 2013-12-12
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Low
Jay Bryant

Bug Description

Cinder test_migrations is failing for test_migration_008, 009, 010, 011, 018 and 020 fail because the test case is checking for a BOOLEAN type but a 'TINYINT' is being returned.

This will require a change similar to changes made for DB2 to check the engine type and update the check accordingly.

Jay Bryant (jsbryant) on 2013-12-12
Changed in cinder:
importance: Undecided → Low
assignee: nobody → Jay Bryant (jsbryant)
Jay Bryant (jsbryant) wrote :

Some details on how to recreate this:

1) Edit cinder/tests/test_migrations.conf
2) Uncomment the mysql line and configure it for your system.
3) Run ./run_tests.sh -V cinder.tests.test_migrations

Fix proposed to branch: master
Review: https://review.openstack.org/65169

Changed in cinder:
status: New → In Progress

Reviewed: https://review.openstack.org/65169
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=2a7b11922bd9389287915c45de92ca5eed3d448e
Submitter: Jenkins
Branch: master

commit 2a7b11922bd9389287915c45de92ca5eed3d448e
Author: Jay S. Bryant <email address hidden>
Date: Mon Jan 6 14:45:34 2014 -0600

    Add bool_type dictionary to test_migrations

    A number of MySQL migration tests fail because the test case
    is verifying that an sqlalchemy.types.BOOLEAN column was created.
    When the column type is checked, however, mysql reports the type as
    sqlalchemy.dialects.mysql.TINYINT. The mismatch causes numerous
    test cases to fail for MySQL.

    This creates a dictionary for each engine being tested to handle the
    different boolean types.

    postgresql and DB2 encounter similar issues. Subsequent patches
    will make the appropriate changes for those databases.

    Change-Id: I81cb3c6feeacf887f1f473ec54414e0e215d2c24
    Closes-bug: 1260126

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2014-01-22
Changed in cinder:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2014-04-17
Changed in cinder:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers