can't run cinder unit tests in parallel reliable

Bug #1259463 reported by Michael Kerrin
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Unassigned

Bug Description

Running cinder unit tests in parallel can reduce the time taken to do a full run from 2m 42 sec to 35 seconds approximately on my workstation. This is a big enough gain to get this to work reliable.

The issue is that we have lots a unit tests that fail when we try to run in parallel. There is no one reason, some use global variables that get modified by other tests, others return different ordering when run in parallel, etc. I am planing on uploaded a number of patches to resolve this.

Changed in cinder:
status: New → Confirmed
importance: Undecided → Low
Ivan Kolodyazhny (e0ne)
Changed in cinder:
assignee: nobody → Ivan Kolodyazhny (e0ne)
Mike Perez (thingee)
Changed in cinder:
status: Confirmed → In Progress
milestone: none → kilo-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/151711

Mike Perez (thingee)
Changed in cinder:
milestone: kilo-2 → kilo-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/151711
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=58507e0a8425ce9ddd0be5a4a9dc5755db432681
Submitter: Jenkins
Branch: master

commit 58507e0a8425ce9ddd0be5a4a9dc5755db432681
Author: Ivan Kolodyazhny <email address hidden>
Date: Fri Jan 30 19:19:03 2015 +0200

    Fix SSHPoolTestCase to work in parallel

    Mock global config for tests in SSHPoolTestCase to make it
    workable in a concurrency mode.

    Change-Id: Ibf6f881d6dfd945abe9c7433367b0acf5b24722a
    Partial-Bug: #1259463

Revision history for this message
Erlon R. Cruz (sombrafam) wrote :

Does this fix all parallel errors for you??

I still get some errors: https://gist.github.com/sombrafam/5b831e66aa26e4513c1b

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/159494

Changed in cinder:
assignee: Ivan Kolodyazhny (e0ne) → Anton Arefiev (aarefiev)
Revision history for this message
Mike Perez (thingee) wrote :

Looks like there are issues with the mocks, and unfortunately we're out of time and no one is around who works on the patch. Moving to l-1.

Changed in cinder:
milestone: kilo-3 → liberty-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/159494
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=9f43ca02a9130fb63b161713f65fd0c568e7245e
Submitter: Jenkins
Branch: master

commit 9f43ca02a9130fb63b161713f65fd0c568e7245e
Author: Anton Arefiev <email address hidden>
Date: Thu Feb 26 11:24:52 2015 +0200

    Fix QoSSpecManageApiTest to work in parallel

    Global notification list for tests in QoSSpecManageApiTest
    raises mismatch exception sometimes.
    Also convert stubs -> mock patch.

    Change-Id: I100ac76a8ae27c92c8c3c628b119eaa61cc8d7fc
    Partial-Bug: #1259463

Mike Perez (thingee)
Changed in cinder:
milestone: liberty-1 → liberty-2
Anton Arefiev (aarefiev)
Changed in cinder:
assignee: Anton Arefiev (aarefiev) → nobody
Revision history for this message
John Griffith (john-griffith) wrote :

I think this is resolved. We've had quite a few patches go in as well as a move to ostestr running parallel by default including gate for a couple months now.

Mike Perez (thingee)
Changed in cinder:
status: In Progress → Fix Committed
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-2 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.