Unhandled exception when "None" is passed in as new_size to extend

Bug #1259336 reported by John Griffith
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Medium
John Griffith

Bug Description

Currently the extend method in the cinder volume_actions extension checks for KeyError and ValueError, however the negative tests in Tempest include passing None in to the new_size which results in an unhandled trace in the test logs.

Add TypeError to the list of exceptions we look for.

Tags: gate-failure
tags: added: gate-failure
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/60962

Changed in cinder:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/60962
Committed: http://github.com/openstack/cinder/commit/bc16517ac7351b715d0202f7beb5a5e0d7ff8f97
Submitter: Jenkins
Branch: master

commit bc16517ac7351b715d0202f7beb5a5e0d7ff8f97
Author: john-griffith <email address hidden>
Date: Mon Dec 9 16:00:20 2013 -0700

    Catch TypeError when new_size is None on extend

    The volume_actions extend method does not catch/handle TypeError
    exceptions. The tempest volume_actions test includes a negative
    test that doesn't pass in a new-size so the result is we get an
    unhandled exception/trace in the log files for these runs.

    Change-Id: I8b699a28e06e62126da02c3318d3129412dffa6b
    Closes-Bug: #1259336

Changed in cinder:
status: In Progress → Fix Committed
Changed in cinder:
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.