migrate_volume dest_vg existence is wrong

Bug #1258203 reported by Flavio Percoco on 2013-12-05
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Medium
Flavio Percoco
Havana
Undecided
Unassigned

Bug Description

    if dest_vg != self.vg.vg_name:
        vg_list = volutils.get_all_volume_groups()
            vg_dict = \
                (vg for vg in vg_list if vg['name'] == self.vg.vg_name).next()

`vg['name'] == self.vg.vg_name` should be `vg['name'] == dest_vg`

https://git.openstack.org/cgit/openstack/cinder/tree/cinder/volume/drivers/lvm.py?h=stable/havana#n703

Changed in cinder:
assignee: nobody → Flavio Percoco (flaper87)

Fix proposed to branch: master
Review: https://review.openstack.org/60271

Changed in cinder:
status: New → In Progress
Eric Harney (eharney) on 2013-12-09
Changed in cinder:
importance: Undecided → Medium

Reviewed: https://review.openstack.org/60271
Committed: http://github.com/openstack/cinder/commit/17912f4c4fba270a15cab47bb68d9e30c34a69b0
Submitter: Jenkins
Branch: master

commit 17912f4c4fba270a15cab47bb68d9e30c34a69b0
Author: Flavio Percoco <email address hidden>
Date: Thu Dec 5 17:05:33 2013 +0100

    LVM migration: Check if name is equal to dest_vg

    The existence check of the destination volume group is wrong. It
    currently checks if there's a VG with a name equal to the source's vg
    name instead of checking if it's equal to the dest_vg.

    Closes-bug: #1258203
    Change-Id: Ia5d4acb24b94c6aa832107c7eb4b6996985af97f

Changed in cinder:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/60958
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=468cfc267211c4d596c4e2bf9bd6ef1ea6a9a002
Submitter: Jenkins
Branch: stable/havana

commit 468cfc267211c4d596c4e2bf9bd6ef1ea6a9a002
Author: Flavio Percoco <email address hidden>
Date: Thu Dec 5 17:05:33 2013 +0100

    LVM migration: Check if name is equal to dest_vg

    The existence check of the destination volume group is wrong. It
    currently checks if there's a VG with a name equal to the source's vg
    name instead of checking if it's equal to the dest_vg.

    Closes-bug: #1258203
    (cherry picked from commit 17912f4c4fba270a15cab47bb68d9e30c34a69b0)

    Change-Id: Ia5d4acb24b94c6aa832107c7eb4b6996985af97f

tags: added: in-stable-havana
Thierry Carrez (ttx) on 2014-01-22
Changed in cinder:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2014-04-17
Changed in cinder:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers