All Cinder Public API controllers should inherit from wsgi.Controller

Bug #1257198 reported by ling-yun on 2013-12-03
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Medium
ling-yun

Bug Description

Most of the Cinder Public API Controllers inherit from wsgi.Controller, but still some Cinder Public APIs controllers directly inherit from object. So it's necessary to unify all the Cinder Public API Controllers inherit from wsgi.Controller.

ling-yun (zengyunling) on 2013-12-03
Changed in cinder:
assignee: nobody → ling-yun (zengyunling)

Fix proposed to branch: master
Review: https://review.openstack.org/59648

Changed in cinder:
status: New → In Progress
Mike Perez (thingee) on 2013-12-04
Changed in cinder:
milestone: none → icehouse-2

Reviewed: https://review.openstack.org/59648
Committed: http://github.com/openstack/cinder/commit/3b2842bf2df46daf4e4d26695c06963499968181
Submitter: Jenkins
Branch: master

commit 3b2842bf2df46daf4e4d26695c06963499968181
Author: ling-yun <email address hidden>
Date: Tue Dec 3 16:19:17 2013 +0800

    All API controllers inherit from wsgi.Controller

    Most of the Cinder Public API Controllers inherit from wsgi.Controller,
    but still some Cinder Public APIs controllers directly inherit from
    object. So it's necessary to unify all the Cinder Public API Controllers
    inherit from wsgi.Controller.
    1. For code cleanup.
    2. When we try to do body valid check in api's put/post method later, we
    can use the helper function is_valid_body instead of using try...catch
    block.

    Change-Id: I88812224e0b182939cfccce63982cb8f95792891
    Closes-Bug: #1257198

Changed in cinder:
status: In Progress → Fix Committed
Changed in cinder:
importance: Undecided → Medium
Thierry Carrez (ttx) on 2014-01-22
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2014-04-17
Changed in cinder:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers