Volume manager re-export failure stops volume service

Bug #1257049 reported by Eric Harney on 2013-12-02
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Eric Harney

Bug Description

In bug 1232177, we made a change to set drivers to "initialized" earlier in the process, so that delete operations run by init_host() work as expected. A side effect of this is that now, a failure to re-export a volume (i.e. tgtadm fails for the LVM driver) causes the volume service to stop.

I believe the driver should not be marked as initialized() until after re-export has finished, which still accounts for the change needed in the prior bug.

Fix proposed to branch: master
Review: https://review.openstack.org/59531

Changed in cinder:
assignee: nobody → Eric Harney (eharney)
status: New → In Progress

Reviewed: https://review.openstack.org/59531
Committed: http://github.com/openstack/cinder/commit/e5d459ae7176f25c2b43606e37c049a52e54e5dc
Submitter: Jenkins
Branch: master

commit e5d459ae7176f25c2b43606e37c049a52e54e5dc
Author: Eric Harney <email address hidden>
Date: Mon Dec 2 14:58:57 2013 -0500

    Don't stop volume service for failed re-export operations

    Commit b71570 "Set vol driver initialized before deleting volumes"
    changed the manager behavior to call set_initialized() before
    attempting to re-export volumes.

    Drivers should not be considered initialized before re-export has
    succeeded. Otherwise a failure to export causes the volume
    service to stop, when that failure should be handled like any other
    failure to initialize.

    Closes-Bug: 1257049
    Related-Bug: 1232177
    Change-Id: Ic6bc89ef3f15dbbc971fdd8c91117cccb5c2801b

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-12-04
Changed in cinder:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2014-04-17
Changed in cinder:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers