Use model_query() instead of session.query in db.*****_destroy

[ling-yun]

Use model_query() instead of session.query in db.volume_destroy, db.volume_type_destroy, db.transfer_destroy and db.snapshot_destroy.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/59257

[Huang Zhiteng (zhiteng-huang)]

I'm not a sqlalchemy expert. So pardon me if the answer is obvious: why using session.query() is considered a bug?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/59257
Committed: http://github.com/openstack/cinder/commit/d54c49a22e3ce147003cc9a926b7b72e8dc9c1a8
Submitter: Jenkins
Branch: master

commit d54c49a22e3ce147003cc9a926b7b72e8dc9c1a8
Author: ling-yun <email address hidden>
Date: Sat Nov 30 17:09:28 2013 +0800

    Use model_query() in db.*****_destroy

    Use model_query() instead of session.query in db.volume_destroy,
    db.volume_type_destroy, db.transfer_destroy and db.snapshot_destroy as
    other methods use.
    model_query function is the query helper which is used in most part of
    cinder/db/sqlalchemy/api.py.

    Change-Id: I97be252df9d40bb97231e3341d5cedec26af2d93
    Closes-Bug: #1256483

[ling-yun (zengyunling)]

To huangzhiteng:
For code cleanup,model_query function is the query helper which is used in most part of
cinder/db/sqlalchemy/api.py.

[Huang Zhiteng (zhiteng-huang)]

So it's coding style issue, that it has nothing to do with function. Personal I wouldn't consider this kind of 'issue' as bug.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/64083