The param 'readonly' for os-update_readonly_flag incorrectly checked

Bug #1254682 reported by zhangyanzi on 2013-11-25
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Low
zhangyanzi

Bug Description

In the function os-update_readonly_flag, the param 'readonly' should be needed as a positional argument.
But it does not check the KeyError.

zhangyanzi (zhangyanzi) on 2013-11-25
Changed in cinder:
assignee: nobody → zhangyanzi (zhangyanzi)
status: New → In Progress

Reviewed: https://review.openstack.org/58261
Committed: http://github.com/openstack/cinder/commit/f1cc8726058a5b3bc4b955e3441e498c2ead8471
Submitter: Jenkins
Branch: master

commit f1cc8726058a5b3bc4b955e3441e498c2ead8471
Author: zhangyanzi <email address hidden>
Date: Mon Nov 25 19:33:49 2013 +0800

    The param 'readonly' is incorrect checked

    In the function os-update_readonly_flag, the param 'readonly' is incorrect
    checked, without the param in request, i think it should raise exception
    with message like "Must specify readonly in request."

    Change-Id: I19e15e988ffa2d093d374f6a33ce94d45ffe2c30
    Closes-bug: 1254682

Changed in cinder:
status: In Progress → Fix Committed
Changed in cinder:
milestone: none → icehouse-1
importance: Undecided → Low
Thierry Carrez (ttx) on 2013-12-04
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2014-04-17
Changed in cinder:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers