Migrate volume should check parameter "host" in request

Bug #1253904 reported by huangtianhua on 2013-11-22
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Undecided
Avishay Traeger

Bug Description

Migrate volume should check parameter "host" in request.

The server doesn't check whether the parameter "host" is in request
body.So the 500 error has been thrown.

We should catch the KeyError and transfer the KeyError to
400(HTTPBadRequest) instead of 500.

Changed in cinder:
assignee: nobody → huangtianhua (huangtianhua)

Fix proposed to branch: master
Review: https://review.openstack.org/57847

Changed in cinder:
status: New → In Progress
Changed in cinder:
assignee: huangtianhua (huangtianhua) → Avishay Traeger (avishay-il)

Reviewed: https://review.openstack.org/57847
Committed: http://github.com/openstack/cinder/commit/58db021240cafb33f602aba50fdaa9060c15d84a
Submitter: Jenkins
Branch: master

commit 58db021240cafb33f602aba50fdaa9060c15d84a
Author: huangtianhua <email address hidden>
Date: Fri Nov 22 15:22:07 2013 +0800

    Migrate volume should check para "host" in request

    The server doesn't check whether the parameter "host" is in request
    body. So the 500 error has been thrown.

    We should catch the KeyError and transfer the KeyError to
    400 (HTTPBadRequest) instead of 500.

    Closes-Bug: #1253904
    Change-Id: I3fb07113816a87f284b47e32bacd57f78a32676c

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-12-04
Changed in cinder:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2014-04-17
Changed in cinder:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers