create snapshot throws 500 Internal Error

Bug #1252179 reported by huangtianhua
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Medium
huangtianhua

Bug Description

The server doesn't check whether the parameter "volume_id"is in request body. So the 500 error has been thrown.

We should catch the KeyError and transfer the KeyError to 400(HTTPBadRequest) instead of 500.

Both v1 and v2 have the same problem.

Tags: api
Changed in cinder:
assignee: nobody → huangtianhua (huangtianhua)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/56886

Changed in cinder:
status: New → In Progress
Changed in cinder:
importance: Undecided → Medium
tags: added: api
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/56886
Committed: http://github.com/openstack/cinder/commit/381e717b4cdebb75f90dc4c62120e8d607f2a98c
Submitter: Jenkins
Branch: master

commit 381e717b4cdebb75f90dc4c62120e8d607f2a98c
Author: huangtianhua <email address hidden>
Date: Mon Nov 18 16:58:45 2013 +0800

    Create snapshot throws 500 Internal Error

    The server doesn't check whether the parameter "volume_id" is in request body.
    So the 500 error has been thrown.

    We should catch the KeyError and transfer the KeyError to 400(HTTPBadRequest)
    instead of 500.

    Change-Id: I8a1dde1fd6ed820b39995af434efacc2a27c9604
    Closes-Bug: #1252179

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.