cinder backup should use pipe for diff transfer

Bug #1244464 reported by Edward Hope-Morley on 2013-10-24
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Critical
Edward Hope-Morley
Havana
Critical
Edward Hope-Morley
cinder (Ubuntu)
Undecided
Unassigned

Bug Description

When the cinder ceph backup driver attempts a differential transfer, the diff is held in memory. This will rapidly become a problem e.g. for bootable volumes, resulting in memory allocation errors.

summary: - cinder backup should use tmp file for diff transfer
+ cinder backup should use pipe for diff transfer
description: updated
Changed in cinder:
status: New → In Progress
assignee: nobody → Edward Hope-Morley (hopem)
Josh Durgin (jdurgin) on 2013-10-25
Changed in cinder:
importance: Undecided → Critical

Reviewed: https://review.openstack.org/53923
Committed: http://github.com/openstack/cinder/commit/d384d28e1c2c7c3ce0bd676fb1c2bdb8a2d98a03
Submitter: Jenkins
Branch: master

commit d384d28e1c2c7c3ce0bd676fb1c2bdb8a2d98a03
Author: Edward Hope-Morley <email address hidden>
Date: Fri Oct 25 10:57:55 2013 -0700

    Use pipe between ceph backup diff export/import

    We now use a piped transfer between the rbd export-diff
    and import-diff for incremental backups/restores as
    opposed to holding the entire diff in memory.

    Change-Id: I33476d9b3934781413af5cd2867a11d825a5d78e
    Fixes: bug 1244464

Changed in cinder:
status: In Progress → Fix Committed
Edward Hope-Morley (hopem) wrote :

Now that this has been appoved, I will nominate it for backport to stable/havana

Changed in cinder:
milestone: none → icehouse-1
Thierry Carrez (ttx) on 2013-12-04
Changed in cinder:
status: Fix Committed → Fix Released

Reviewed: https://review.openstack.org/54589
Committed: http://github.com/openstack/cinder/commit/022f1df261d15ca8faa89382974e772473bce69d
Submitter: Jenkins
Branch: stable/havana

commit 022f1df261d15ca8faa89382974e772473bce69d
Author: Edward Hope-Morley <email address hidden>
Date: Fri Oct 25 10:57:55 2013 -0700

    Use pipe between ceph backup diff export/import

    We now use a piped transfer between the rbd export-diff
    and import-diff for incremental backups/restores as
    opposed to holding the entire diff in memory.

    Change-Id: I33476d9b3934781413af5cd2867a11d825a5d78e
    Fixes: bug 1244464
    (cherry picked from commit d384d28e1c2c7c3ce0bd676fb1c2bdb8a2d98a03)

Thierry Carrez (ttx) on 2014-04-17
Changed in cinder:
milestone: icehouse-1 → 2014.1
Paul White (paulw2u) on 2016-06-11
affects: ubuntu → cinder (Ubuntu)
Changed in cinder (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers