generate_sample script can't handle MultiStrOpt when is blank list

Bug #1241348 reported by Xingchao Yu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Xingchao Yu

Bug Description

In case if opt type it multistropt and the value is [].
Then extract_opts.py can't handle this case, and will skip this option return blank content.

Revision history for this message
Xingchao Yu (yuxcer) wrote :

See the bug I report yeterday: https://bugs.launchpad.net/cinder/+bug/1240783

Changed in cinder:
assignee: nobody → Xingchao Yu (yuxcer)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/52573

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/52573
Committed: http://github.com/openstack/cinder/commit/e5aa6e72734738e81d1b8be51ae3bb39db50f8a3
Submitter: Jenkins
Branch: master

commit e5aa6e72734738e81d1b8be51ae3bb39db50f8a3
Author: Xingchao Yu <email address hidden>
Date: Fri Oct 18 13:50:18 2013 +0800

    Fix generate conf script can't handle multistropt

    In case MultiStrOpt option's value is empty list, current extract_opts.py
    logic will ignore it. This patch aims to update func _print_opt:

    add the multistropt's option_name in conf even its value is empty list.

    This bug also affects https://bugs.launchpad.net/cinder/+bug/1240783

    Closes-bug: #1241348

    Change-Id: Ica1da0cd20c97a587964cb0059836d609a440145

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.