VMware: size of volume created from image should be based on user input

[Ryan Hsu]

With VC VMDK cinder driver, the size of volumes created from image is currently based on the size of the image and the size input by the user is ignored. So if the image in the following command is 1GB,

    cinder create --image-id <image> 5

The 5GB is effectively ignored and the volume is created as 1GB.

Instead of this behavior, we should create a 5GB volume and then copy in the image.

[Subbu (subramanian-neelakantan)]

Hi Vincent, just wanted to let you know that the code around copy_image_to_volume is changing a lot with the fix for https://bugs.launchpad.net/cinder/+bug/1229998. I am planning to update the patch for bug 1229998 in a few hours. Please pull those changes in before trying to fix this.

[Vincent Hou (houshengbo)]

Thank you, Subbu. Sure I will.

[Ryan Hsu (rhsu)]

The same issue is occurring with creating a volume from a volume snapshot. Would the code for fixing volume-from-image also fix volume-from-volume snapshot? Please let me know if a new bug needs to be created.

[Sreeram Yerrapragada (syerrapragada)]

The same issue is occuring with launching an instance using "Boot from image (Creates volume)" option in horizon

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/59924

[Vincent Hou (houshengbo)]

Hi Ryan ad Sreeram. Please help me to review the patch I submitted. https://review.openstack.org/59924

It resolves the issue of creating the volume from snapshot as well. Thx.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/63060

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/66240

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/66994

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/67012

[Vincent Hou (houshengbo)]

Please review the patch https://review.openstack.org/#/c/67012/ for this issue.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/67012
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=015555acb75ee4d9298915951d2bfaf0d19d2b02
Submitter: Jenkins
Branch: master

commit 015555acb75ee4d9298915951d2bfaf0d19d2b02
Author: Vincent Hou <email address hidden>
Date: Wed Dec 4 03:51:20 2013 -0500

    VMware: Take the volume size from the user input

    When we create a volume from an image or a snapshot, we need to
    take the size of the volume from the user input and validate whether
    the size is appropriate instead of taking the image size as the
    volume size directly.

    Change-Id: If09933d8ffa989c4dacc0860c19ea332bc21092a
    Closes-Bug: #1237557