HostManager doesn't have get_host_list() method

Bug #1236723 reported by Kiyohiro Adachi on 2013-10-08
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Undecided
Kiyohiro Adachi

Bug Description

cinder.scheduler.host_manager.HostManager doesn't have get_host_list()
and get_service_capabilities() method.

But I look like which cinder.scheduler.driver.Scheduler is trying to call them.
Are they not being used? I think they can be deleted.

Kiyohiro Adachi (adachi) on 2013-10-08
Changed in cinder:
assignee: nobody → Kiyohiro Adachi (adachi)

Fix proposed to branch: master
Review: https://review.openstack.org/50232

Changed in cinder:
status: New → In Progress

Reviewed: https://review.openstack.org/50232
Committed: http://github.com/openstack/cinder/commit/f330eac22ad47901ccd3252ffd73c46d7157644e
Submitter: Jenkins
Branch: master

commit f330eac22ad47901ccd3252ffd73c46d7157644e
Author: KIYOHIRO ADACHI <email address hidden>
Date: Tue Oct 8 16:28:25 2013 +0900

    remove unused methods in driver.Scheduler

    cinder.scheduler.host_manager.HostManager doesn't have get_host_list()
    and get_service_capabilities(). But we don't catch the AttributeError
    by them. Therefore, get_host_list() and get_service_capabilities() in
    cinder.scheduler.driver.Scheduler have not been used.

    Also, get_host_list() and get_service_capabilities() in
    cinder.scheduler.manager.SchedulerManager have not been used.

    Change-Id: I402cf068612866649cc8645391eff38fca56f634
    Closes-Bug: #1236723

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-12-04
Changed in cinder:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2014-04-17
Changed in cinder:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers