ThinLVMVolumeDriver missing upgrade path from Grizzly

Bug #1231116 reported by Eric Harney on 2013-09-25
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Medium
Eric Harney

Bug Description

Users with volume_driver=cinder.volume.drivers.lvm.ThinLVMVolumeDriver will find that this driver no longer exists after upgrading to Havana.

Normally this is handled by adding an entry to MAPPING in volume/manager.py, but for this driver, we must also set "lvm_type=thin" as well as "volume_driver=...LVMISCSIDriver".

Fix proposed to branch: master
Review: https://review.openstack.org/48336

Changed in cinder:
assignee: nobody → Eric Harney (eharney)
status: New → In Progress
John Griffith (john-griffith) wrote :

IMO this should be addressed via documentation, in other words open a docs issue for it and address it there. I don'b believe take-up on LVM-Thin was great enough to have a very significant impact (especially since there was no official package supporting it on 12.04 LTS).

I realize there may be customers that are using this, but I think it's fair to document in the release notes and in the Havana docs that this has changed. Continuing to MAP drivers names forever seems to be getting cumbersome.

Changed in cinder:
importance: Undecided → Medium
Eric Harney (eharney) wrote :

Should probably fix this for havana-rc1 if possible.

Changed in cinder:
milestone: none → havana-rc1
Eric Harney (eharney) wrote :

Well, IMO, we can remove this mapping in Icehouse. But I think it makes sense for Havana.

Reviewed: https://review.openstack.org/48336
Committed: http://github.com/openstack/cinder/commit/63fc867ab709a20c3417cada12b327774bf612e6
Submitter: Jenkins
Branch: master

commit 63fc867ab709a20c3417cada12b327774bf612e6
Author: Eric Harney <email address hidden>
Date: Wed Sep 25 15:43:32 2013 -0400

    Allow upgrade from Grizzly with ThinLVMVolumeDriver

    In Grizzly, LVM thin provisioning was used by setting
    volume_driver=...ThinLVMVolumeDriver. In Havana this
    functionality has moved under the standard LVM driver
    with the option "lvm_type=thin" used to enable it.

    We should account for the old volume_driver class path
    so that the volume service behaves as expected for users
    upgrading from Grizzly ThinLVM configurations.

    Closes-Bug: #1231116
    Change-Id: Ic29f0e5c1036232078af5c6d83c61c75a35cccd4

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-10-04
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in cinder:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers