Migration 009, 010, 020 downgrade failures do not raise exceptions

Bug #1227881 reported by Eric Harney on 2013-09-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Medium
Rushi Agrawal

Bug Description

009_add_snapshot_metadata_table.py, 010_add_transfers_table.py, and 020_add_volume_admin_metadata_table.py all contain a downgrade() method which does a try: except: and does not raise the exception again after logging it.

Looking at the other migration scripts (008, 015, etc.), I suspect we want these to raise an exception upon failure.

Changed in cinder:
status: New → Confirmed
importance: Undecided → Medium
Rushi Agrawal (rushiagr) on 2013-11-26
Changed in cinder:
assignee: nobody → Rushi Agrawal (rushiagr)
Changed in cinder:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/58442
Committed: http://github.com/openstack/cinder/commit/3ddf4511596b2fcfc4ec134cd9edaeaba823e42b
Submitter: Jenkins
Branch: master

commit 3ddf4511596b2fcfc4ec134cd9edaeaba823e42b
Author: Rushi Agrawal <email address hidden>
Date: Tue Nov 26 11:48:38 2013 +0530

    Fix suppressed exceptions for migration downgrade

    In SQLAlchemy migration versions 009, 010 and 020, we missed
    reraising exceptions while logging errors in case of a downgrade.
    We don't want exceptions to pass silently. This patch fixes that.

    Closes-bug: 1227881

    Change-Id: Id11b1c5d2e26d208e88bb84e5b46c4b7affc3f9f

Changed in cinder:
status: In Progress → Fix Committed
Changed in cinder:
milestone: none → icehouse-1
Thierry Carrez (ttx) on 2013-12-04
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2014-04-17
Changed in cinder:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers