Argument of exception.GlanceConnectionFailed is incorrect in glance.py

Bug #1226959 reported by Kiyohiro Adachi on 2013-09-18
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Undecided
Kiyohiro Adachi

Bug Description

cinder/cinder/image/glance.py is used as follows.

  raise exception.GlanceConnectionFailed(netloc=netloc,
                                         reason=str(e))

'netloc' is always ignored.

Kiyohiro Adachi (adachi) on 2013-09-18
Changed in cinder:
assignee: nobody → Kiyohiro Adachi (adachi)

Fix proposed to branch: master
Review: https://review.openstack.org/47093

Changed in cinder:
status: New → In Progress

Reviewed: https://review.openstack.org/47093
Committed: http://github.com/openstack/cinder/commit/3cc149a802346bef063bcb865182e4e21ec8b086
Submitter: Jenkins
Branch: master

commit 3cc149a802346bef063bcb865182e4e21ec8b086
Author: KIYOHIRO ADACHI <email address hidden>
Date: Wed Sep 18 15:59:28 2013 +0900

    Fixes call GlanceConnectionFailed in invalid ARG

    A mapping key of 'netloc' is always ignored. Thus information in
    'netloc' is lost. But because it is included in 'error_msg', I remove
    'netloc=netloc'.

    Change-Id: I937044bcca0cb196fcd96cfa421de777713d76f5
    Closes-Bug: #1226959

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-10-04
Changed in cinder:
milestone: none → havana-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in cinder:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers