Bug in __init__ of cinder.brick.initiator.connector.RemoteFSConnector

Bug #1226830 reported by Victor Rodionov on 2013-09-17
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Undecided
Victor Rodionov

Bug Description

Wrong arguments orders in super call of cinder.brick.initiator.connector.RemoteFSConnector

class InitiatorConnector(executor.Executor):
    def __init__(self, root_helper, driver=None,
                 execute=putils.execute, *args, **kwargs):
        super(InitiatorConnector, self).__init__(root_helper, execute,
                                                 *args, **kwargs)
        if not driver:
            driver = host_driver.HostDriver()
        self.set_driver(driver)

class RemoteFsConnector(InitiatorConnector):
    """Connector class to attach/detach NFS and GlusterFS volumes."""

    def __init__(self, mount_type, root_helper, driver=None,
                 execute=putils.execute, *args, **kwargs):
        self._remotefsclient = remotefs.RemoteFsClient(mount_type,
                                                       execute, root_helper)
        super(RemoteFsConnector, self).__init__(driver, execute, root_helper,
                                                *args, **kwargs)

driver and execute arguments should be after root_helper

Changed in cinder:
assignee: nobody → Victor Rodionov (vito-ordaz)
status: New → In Progress

Reviewed: https://review.openstack.org/47032
Committed: http://github.com/openstack/cinder/commit/587a7e35aa7f0c1cccfa366b795424ba55808e1a
Submitter: Jenkins
Branch: master

commit 587a7e35aa7f0c1cccfa366b795424ba55808e1a
Author: Victor Rodionov <email address hidden>
Date: Wed Sep 18 01:22:05 2013 +0400

    Fix __init__ methods of brick initiator connectors

    Wrong order of positional arguments in RemoteFsConnector __init__ call.
    This only in RemoteFsConnector.__init__, but I decide also update
    __init__ methods of other connectors to avoid errors in future.

    Change-Id: I75d2c2d29e0330536e280614db1a13686cfd15e4
    Closes-Bug: #1226830

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-10-04
Changed in cinder:
milestone: none → havana-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in cinder:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers