Argument of exception.VolumeNotFound is incorrect in storwize_svc.py

Bug #1226442 reported by Kiyohiro Adachi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Kiyohiro Adachi

Bug Description

cinder/volume/drivers/storwize_svc.py is used as follows.

  raise exception.VolumeNotFound(exception_msg,
                                 volume_id=src_id)

If 'exception_msg' is used, 'volume_id=src_id' is ignored.

Likewise,

  raise exception.SnapshotNotFound(exception_msg,
                                   snapshot_id=src_id)

If 'exception_msg' is used, 'snapshot_id=src_id' is ignored.

Therefore, information in 'src_id' is lost from the exception message.

Kiyohiro Adachi (adachi)
Changed in cinder:
assignee: nobody → Kiyohiro Adachi (adachi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/46891

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/46891
Committed: http://github.com/openstack/cinder/commit/a8fcfdbe8b2f46a100f986eeef5c7d43aef69bb7
Submitter: Jenkins
Branch: master

commit a8fcfdbe8b2f46a100f986eeef5c7d43aef69bb7
Author: KIYOHIRO ADACHI <email address hidden>
Date: Tue Sep 17 16:08:55 2013 +0900

    Fixes call VolumeNotFound in the invalid argument

    A mapping key of 'volume_id' is ignored when we use the non keyword
    argument. Thus information in 'volume_id' is lost. Similarly, in the
    case of exception.SnapshotNotFound, information in 'snapshot_id' is
    lost.

    Change-Id: I1a704cc1866ad9b0d9578e16e77c376a77ea5b3e
    Closes-Bug: #1226442

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → havana-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.