cinder.conf should default rootwrap_config path like nova

Bug #1226074 reported by Matt Riedemann on 2013-09-16
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Low
Jay Bryant

Bug Description

The nova.conf.sample defaults the path for the nova rootwrap.conf file:

https://github.com/openstack/nova/blob/master/etc/nova/nova.conf.sample#L274

The cinder.conf.sample doesn't default the path:

https://github.com/openstack/cinder/blob/master/etc/cinder/cinder.conf.sample#L419

But the cmd.py entry point documents that it should be set:

https://github.com/openstack/cinder/blob/master/cinder/openstack/common/rootwrap/cmd.py#L25

So we should just set it in cinder.conf.sample so it's turned on by default to the proper path like nova does.

Jay Bryant (jsbryant) on 2013-09-16
Changed in cinder:
assignee: nobody → Jay Bryant (jsbryant)
Eric Harney (eharney) on 2013-09-16
Changed in cinder:
importance: Undecided → Low
milestone: none → havana-rc1
Jay Bryant (jsbryant) wrote :

Eric Harney and I discussed this with Matt in IRC. Seems that we should change this to be consistent with the other components. I will submit a patch.

Fix proposed to branch: master
Review: https://review.openstack.org/46784

Changed in cinder:
status: New → In Progress

Reviewed: https://review.openstack.org/46784
Committed: http://github.com/openstack/cinder/commit/3394045316a113904fef510f2aff7305d2eb0826
Submitter: Jenkins
Branch: master

commit 3394045316a113904fef510f2aff7305d2eb0826
Author: Jay S. Bryant <email address hidden>
Date: Mon Sep 16 13:21:34 2013 -0500

    Set rootwrap_config path to rootwrap.conf

    Other components set
    rootwrap_config = /etc/<component>/rootwrap.conf by default.
    This commit brings cinder up-to-date with what other
    components are doing by setting
    rootwrap_config = /etc/cinder/rootwrap.conf by default.

    A couple of test cases needed to be updated to handle the change
    from 'None'.

    Not counting this as a documentation impact as the documentation I
    can find already lists /etc/cinder/rootwrap.conf as the default.

    Closes-Bug 1226074

    Change-Id: I68dd5fea1895a6365d6c69db0535d081c4a3460e

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-10-04
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in cinder:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers