hp3par driver and common should log errors before raising exception

Bug #1225235 reported by Walt Boring on 2013-09-13
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Walt Boring

Bug Description

There are exceptions in the 3par iscsi driver and the 3par common class that aren't being logged. We can no longer assume upstream code will log our exceptions.

Eric Harney (eharney) wrote :

This should just be fixed in the volume manager. See bug 1225897.

Changed in cinder:
status: New → Confirmed

Fix proposed to branch: master
Review: https://review.openstack.org/46831

Changed in cinder:
status: Confirmed → In Progress
Jay Bryant (jsbryant) wrote :

Eric, there was a discussion on IRC between Walt, John and I about this issue. While changes may be appropriate to the volume manager (and will be needed as we go through the process of trying to improve exception handling) the agreement that we came to was that it was the responsibility of the driver owner to log whatever they felt was important in their code. So, the recommendation for Walt was to add error logging before raising the exceptions.

Given the time that this bug was opened, I am guessing that is the discussion that sparked this issue.

John Griffith (john-griffith) wrote :

Like Jay said, there's multiple pieces to this IMO, and things should probably start with better logging in the driver. I'm not certain why there would be an objection a driver adding additional logging anyway.

The manager does need some fixes that are being addressed, but cleaning up the error management in the driver is a good thing as well IMO.

Reviewed: https://review.openstack.org/46831
Committed: http://github.com/openstack/cinder/commit/04ec96cdc95396ba2f35493a632b603d182ab6ae
Submitter: Jenkins
Branch: master

commit 04ec96cdc95396ba2f35493a632b603d182ab6ae
Author: Walter A. Boring IV <email address hidden>
Date: Mon Sep 16 15:31:20 2013 -0700

    Add logging to prior to raising exceptions

    This patch fixes an issue where exceptions
    happen in the 3PAR drivers and the exceptions
    aren't being logged to the log file.

    Fixes bug #1225235

    Change-Id: I8ec26fe3bee65106e01e956472e06acf1d5b9f77

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-10-04
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in cinder:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers