LVM clear_volume should raise exc. if volume_clear opt is invalid

Bug #1225194 reported by Eric Harney on 2013-09-13
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Cinder
Medium
Eric Harney

Bug Description

Currently if a user configures volume_clear='non_existent_volume_clearer' in cinder.conf, the LVM driver will silently delete a volume and not wipe it.

Instead, the delete operation should fail, leaving the volume in the 'error_deleting' state. This prevents a user from believing their volumes are being wiped when they are not due to misconfiguration.

Eric Harney (eharney) on 2013-09-13
Changed in cinder:
assignee: nobody → Eric Harney (eharney)

Fix proposed to branch: master
Review: https://review.openstack.org/46572

Changed in cinder:
status: New → In Progress

Reviewed: https://review.openstack.org/46572
Committed: http://github.com/openstack/cinder/commit/863ae9f484089aa5d9e576255b39288da82c1100
Submitter: Jenkins
Branch: master

commit 863ae9f484089aa5d9e576255b39288da82c1100
Author: Eric Harney <email address hidden>
Date: Fri Sep 13 16:56:44 2013 -0400

    LVM volume_clear: error on unexpected inputs

    Currently if a user configures
    volume_clear='non_existent_volume_clearer' in cinder.conf,
    the LVM driver will silently delete a volume and not wipe it.

    Instead, the delete operation should fail, leaving the volume
    in the 'error_deleting' state.

    Also fail if the volume reference does not contain either a
    'size' or 'volume_size' field.

    Closes-Bug: #1225194
    Change-Id: I78fec32d7d5aeaa8e2deeac43066ca5e2e26d9ca

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-10-04
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in cinder:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers