Don't need to init testr explicitly

Bug #1216820 reported by Kui Shi on 2013-08-26
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Undecided
Kui Shi

Bug Description

In run_tests.sh, function init_testr will initialize testr if the
directory .testrepository is not existed. Actually, testr will do
the check before run the test:

In Python package testrepository, setuptools_command.py:Testr.run

68 def run(self):
69 """Set up testr repo, then run testr"""
70 if not os.path.isdir(".testrepository"):
71 self._run_testr("init")

So, init_testr can be removed safely.

Kui Shi (skuicloud) on 2013-08-26
Changed in cinder:
assignee: nobody → Kui Shi (skuicloud)

Fix proposed to branch: master
Review: https://review.openstack.org/44418

Changed in cinder:
status: New → In Progress

Reviewed: https://review.openstack.org/44418
Committed: http://github.com/openstack/cinder/commit/059bc7a08cea2704853beb4543a2df1f9b3080f0
Submitter: Jenkins
Branch: master

commit 059bc7a08cea2704853beb4543a2df1f9b3080f0
Author: Kui Shi <email address hidden>
Date: Fri Aug 30 15:18:10 2013 +0800

    Don't need to init testr explicitly

    In run_tests.sh, function init_testr will initialize testr if the
    directory .testrepository is not existed. Actually, testr will do
    the check before run the test:

    In Python package testrepository, setuptools_command.py:Testr.run

    68 def run(self):
    69 """Set up testr repo, then run testr"""
    70 if not os.path.isdir(".testrepository"):
    71 self._run_testr("init")

    So, init_testr can be removed safely.

    Fixes Bug #1216820
    Change-Id: Id9815033c0cb0e1aa6693a4c14bf9a5d490c8883

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-09-05
Changed in cinder:
milestone: none → havana-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in cinder:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers