cinder test utils is_installed doesn't work

Bug #1213226 reported by John Griffith
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
Michael Kerrin

Bug Description

The check for cinder is installed (cinder.tests.utils:is_cinder_installed()) is bogus. It will always return False and as a result cause the unit tests for the scheduler to always be skipped.

The reason is that the path and the designation for cinder.egg-info is wrong. Easily fixed here: https://gist.github.com/j-griffith/6252944

However this reveals that one of the unit tests is failing and needs fixed.

Changed in cinder:
status: New → Triaged
importance: Undecided → High
milestone: none → havana-3
Changed in cinder:
assignee: nobody → John Griffith (john-griffith)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/42413

Changed in cinder:
status: Triaged → In Progress
Changed in cinder:
assignee: John Griffith (john-griffith) → Michael Kerrin (michael-kerrin-w)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/41888
Committed: http://github.com/openstack/cinder/commit/998bee4a5da75a9eb39b6d3bdc6a96791fb6d8aa
Submitter: Jenkins
Branch: master

commit 998bee4a5da75a9eb39b6d3bdc6a96791fb6d8aa
Author: Michael Kerrin <email address hidden>
Date: Wed Aug 14 10:16:42 2013 +0000

    Re-enable a lot of cinder scheduler tests

    This highlight and fixes a NoneType exception in the schedulers
    _get_weighted_candidates method

    This was originally added to get around the fact that the filter tests
    required that cinder was correctly installed on the system. But the
    is_cinder_installed condition always returning False and this hid
    problems of old packages been installed in our system. Also
    930f5891b0815e1b49b9b2cc840e0c24b2796e84 added the setup.py automatically
    to run_tests.sh so we can remove this.

    See https://review.openstack.org/#/c/20213/ for history.

    Fixes bug: 1213226

    Change-Id: I86fee802c0543355471ddbd712e52ccec750cea0

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.