3PAR volumes created from snapshots have the snapshop display name in the backend comment field instead of the new volume name.

Bug #1210245 reported by Michael Denny on 2013-08-08
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Undecided
Kurt Martin

Bug Description

Creating a volume from a snapshot causes JSON comments to get out of sync.
The JSON comments in the clone have the info for the original volume which will really cause issues for the clone
JSON Comments have become unreliable, seems we need to refactor by eliminating json in the comments

Michael Denny (michael-denny) wrote :

in comments snap name and vol name are the same "name": "testsp-0-testvol-0-4"

snap comments
{"description": "Created by qaStessTest thread-0", "volume_id": "aa137db3-985c-49e0-83c1-bcdc8c83852a", "name": "testsp-0-testvol-0-4", "volume_name": "volume-aa137db3-985c-49e0-83c1-bcdc8c83852a"}

Vol from snap comments
{"description": "Created by qaStessTest thread-0", "snapshot_id": "a1162390-eb29-4a36-9b89-7bfa75526a8e", "name": "testsp-0-testvol-0-4", "volume_id": "1a61d761-e8c3-4918-99fc-d194cfbb0cb2"}

Kurt Martin (kurt-f-martin) wrote :

The comment item that is incorrect here is the just the name, the driver was using the snapshot display name instead of the volume display name, the rest of the comment data is correct.

Changed in cinder:
assignee: nobody → Kurt Martin (kurt-f-martin)
summary: - 3PAR cloned volumes have the same JSON comments as the original volume
+ 3PAR volumes created from snapshots have the display name in the volume
+ comments
summary: - 3PAR volumes created from snapshots have the display name in the volume
- comments
+ 3PAR volumes created from snapshots have the snapshop display name in
+ the backend comment field instead of the new volume name.
Changed in cinder:
status: New → Confirmed
Kurt Martin (kurt-f-martin) wrote :

The description field also had the same problem as the display_name.

tags: added: 3par drivers

Fix proposed to branch: master
Review: https://review.openstack.org/40974

Changed in cinder:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/40974
Committed: http://github.com/openstack/cinder/commit/7d57146bc4201c9d26de7f7f5a4a834ca0dafa7b
Submitter: Jenkins
Branch: master

commit 7d57146bc4201c9d26de7f7f5a4a834ca0dafa7b
Author: Kurt Martin <email address hidden>
Date: Thu Aug 8 14:14:56 2013 -0700

    3PAR drivers creating incorrect comment data

    The 3PAR volumes created from a shapshot had incorrect comment data
    that gets added in the comment section of the volumes on the backend.
    This patch fixes the display name and description by getting the correct
    data when the volume is created. This patch also fixes the inconsistency
    in how the keys (name vs. display_name) were used in the comments.

    Change-Id: I61af8ceb08d862f2b9dea2d9bb44c803e0b75a10
    Fixes: bug 1210245

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-09-05
Changed in cinder:
milestone: none → havana-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in cinder:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers