LVM fails when accessing volume_clear option

Bug #1208964 reported by Avishay Traeger on 2013-08-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
High
John Griffith

Bug Description

This patch moved volume_clear and volume_clear_size out of lvm.py, and replaced it with imports: https://review.openstack.org/#/c/39497/

However, when deleting an LVM volume, I get the following error:
NoSuchOptError: no such option in group lvmdriver-2: volume_clear

It seems it's because the LVM driver does:
self.configuration.append_config_values(volume_opts)

And volume_opts no longer contains the necessary options.

Changed in cinder:
importance: Undecided → High
tags: added: drivers lvm
Changed in cinder:
assignee: nobody → Nikolay Sobolevsky (xbsd-nikolay)
John Griffith (john-griffith) wrote :

So to clarify a bit, this is in the case of multiple back-ends. The config grouping should have probably been moved up the chain in to the main driver file if non-LVM drivers want to utilize the setting.

I'll move them up in to the main volume_opts config group, and folks can use them in other places (like block_device) if desired. Ideally we should probably make this configurable on each back-end independently at some point.

Changed in cinder:
assignee: Nikolay Sobolevsky (xbsd-nikolay) → John Griffith (john-griffith)
status: New → In Progress

Fix proposed to branch: master
Review: https://review.openstack.org/40499

Changed in cinder:
milestone: none → havana-3

Reviewed: https://review.openstack.org/40499
Committed: http://github.com/openstack/cinder/commit/8aac388cc091b6c79c2d0650810acf72a1097446
Submitter: Jenkins
Branch: master

commit 8aac388cc091b6c79c2d0650810acf72a1097446
Author: John Griffith <email address hidden>
Date: Tue Aug 6 14:58:02 2013 -0600

    Move volume_clear and clear_size opts up to driver

    The block_device driver pulled in the clear and clear_size
    options for it's own use and broke the inheritance model needed
    for multiple backend configs.

    This change moves the two configs up higher in the heirarchy to
    driver.py so that it can be shared/used by all drivers if they desire.

    This means that they are now set properly in volume_opts. At some
    point we shoudl restructure this a bit to allow multi-backends to
    specify independent settings for these configs.

    Fixes bug: 1208964

    Change-Id: I6afbdecea637f7e7d3417be537ab71fe97bffda3

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-09-05
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in cinder:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers