cinder snapshot-list does not report metadata

[Ollie Leahy]

The cinder volume api get_snapshot() does not get the snapshot metadata.

For example the cinder client command snapshot-show for a snapshot that has
entries in the snapshot_metadata table incorrectly indicates that there is no
metadata for the snapshot.

$ cinder snapshot-show 2beeb33d-d3bd-4dd2-9ec9-76ab2e2b2228
+--------------------------------------------+--------------------------------------+
| Property | Value |
+--------------------------------------------+--------------------------------------+
| created_at | 2013-07-24T07:10:21.000000 |
| display_description | None |
| display_name | None |
| id | 2beeb33d-d3bd-4dd2-9ec9-76ab2e2b2228 |
| metadata | {} |
| os-extended-snapshot-attributes:progress | None |
| os-extended-snapshot-attributes:project_id | 22c115f8f67340f599d832945ba09772 |
| size | 1 |
| status | available |
| volume_id | 6f295579-d81e-4e33-9b81-2813ba65663e |
+--------------------------------------------+--------------------------------------+

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/38445

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/38445
Committed: http://github.com/openstack/cinder/commit/99a6f4f9e5b13cd9a3e5c90a5ff11eab9ad92642
Submitter: Jenkins
Branch: master

commit 99a6f4f9e5b13cd9a3e5c90a5ff11eab9ad92642
Author: Ollie Leahy <email address hidden>
Date: Wed Jul 24 10:06:41 2013 +0000

    get_snapshot should populate the snapshot metadata

    Update the query in db api snapshot_get() to join with the table
    snapshot_metadata, so that snapshot metadata is returned. This makes the
    api snapshot_get() function in the same way as volume_get().

    Fixes: bug #1204446

    Change-Id: I37004140f6a11b96aaeb3af6c631028a44541d3a