'is_public' filter should be handled when nova calls glance via V2

[Amala Basha]

During an image- list call via Nova, it appends an 'is_public:None' to the filters, to ensure that private images are not filtered out. In glance V2 Api, this value should be parsed to something useful, say returning True and preserving the default behaviour of returning all public images ( As is done in V1). Currently image-list to V2 via Nova returns an empty list.

[Amala Basha (amalabasha)]

Is_public filter is replaced by 'visibility' in glance V2, so also sending is_public might seem inappropriate

[Andrew Laski (alaski)]

novaclient doesn't append the is_public param, nova does.

[Andrew Laski (alaski)]

Nova is currently hardcoded to use the Glance V1 api for the image-list call. Therefore it's not really a bug at the moment for it to use V1 specific params.

If/when Nova uses the V2 api for the image-list call then this becomes an issue.

[Iccha Sethi (iccha-sethi)]

I am not sure this is a glance v2 bug. Nova should use the glance v2 api correctly.

[Mark Washenberger (markwash)]

Not a glance bug.

[Mehdi Abaakouk (sileht)]

I add cinder too: https://github.com/openstack/cinder/blob/master/cinder/image/glance.py#L258

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/296998

[Matt Riedemann (mriedem)]

The nova part of this needs to be fixed in the glance v2 support blueprint:

https://blueprints.launchpad.net/nova/+spec/use-glance-v2-api

[OpenStack Infra (hudson-openstack)]

Change abandoned by Mehdi Abaakouk (sileht) (<email address hidden>) on branch: master
Review: https://review.openstack.org/296998
Reason: Well two months to get reviewed, no more for me.
Takeover my change if you want your software fixed, or keep it buggy.

Cheers.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/296998
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=4e7624ed65626bd34fa354eb50bc7228f0dd0e26
Submitter: Jenkins
Branch: master

commit 4e7624ed65626bd34fa354eb50bc7228f0dd0e26
Author: Mehdi Abaakouk <email address hidden>
Date: Thu Mar 24 11:23:17 2016 +0100

    image: don't use is_public with glance V2 API

    Glance v2 API has replaced "is_public" argument with "visibility", and,
    unlike "is_public" the default value of "visibility" returns all images,
    which is what we want to get when no value has been provided.

    This patch makes sure that we only send a default value for "is_public"
    when it's not defined when working with API v1.

    Closes-bug: #1201266
    Co-Authored-By: Gorka Eguileor <email address hidden>
    Change-Id: I9ca13567744dbe5895012429679e013b859dbb03

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/316048

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/316048
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=b472931a7f3a897d65d15df1a2f9146397365475
Submitter: Jenkins
Branch: stable/mitaka

commit b472931a7f3a897d65d15df1a2f9146397365475
Author: Mehdi Abaakouk <email address hidden>
Date: Thu Mar 24 11:23:17 2016 +0100

    image: don't use is_public with glance V2 API

    Glance v2 API has replaced "is_public" argument with "visibility", and,
    unlike "is_public" the default value of "visibility" returns all images,
    which is what we want to get when no value has been provided.

    This patch makes sure that we only send a default value for "is_public"
    when it's not defined when working with API v1.

    Closes-bug: #1201266
    Co-Authored-By: Gorka Eguileor <email address hidden>
    Change-Id: I9ca13567744dbe5895012429679e013b859dbb03
    (cherry picked from commit 4e7624ed65626bd34fa354eb50bc7228f0dd0e26)

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/cinder 9.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Mike Fedosin (<email address hidden>) on branch: master
Review: https://review.openstack.org/238309

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/cinder 8.1.0 release.