_update_volume_status() private method is called by get_volume_stats(). This is confusing as the volume's stats and not status gets updated.
The method's name in the base driver and the implemented driver should be fixed. Any related confusing comments should also be fixed.
Identified the following places in the code where 'status' should be changed to 'stats':
cinder/tests/test_volume.py:1544: self.volume.driver._update_volume_status()
cinder/volume/driver.py:493: self._update_volume_status()
cinder/volume/driver.py:497: def _update_volume_status(self):
cinder/volume/drivers/emc/emc_smis_common.py:855: def update_volume_status(self):
cinder/volume/drivers/emc/emc_smis_iscsi.py:229: self.update_volume_status()
cinder/volume/drivers/emc/emc_smis_iscsi.py:233: def update_volume_status(self):
cinder/volume/drivers/emc/emc_smis_iscsi.py:236: data = self.common.update_volume_status()
cinder/volume/drivers/huawei/huawei_iscsi.py:554: self._update_volume_status()
cinder/volume/drivers/huawei/huawei_iscsi.py:1504: def _update_volume_status(self):
cinder/volume/drivers/lvm.py:590: self._update_volume_status()
cinder/volume/drivers/lvm.py:594: def _update_volume_status(self):
cinder/volume/drivers/lvm.py:717: self._update_volume_status()
cinder/volume/drivers/lvm.py:721: def _update_volume_status(self):
cinder/volume/drivers/netapp/iscsi.py:545: self._update_volume_status()
cinder/volume/drivers/netapp/iscsi.py:549: def _update_volume_status(self):
cinder/volume/drivers/netapp/iscsi.py:832: def _update_volume_status(self):
cinder/volume/drivers/netapp/iscsi.py:1115: def _update_volume_status(self):
cinder/volume/drivers/netapp/nfs.py:185: def _update_volume_status(self):
cinder/volume/drivers/netapp/nfs.py:187: super(NetAppNFSDriver, self)._update_volume_status()
cinder/volume/drivers/netapp/nfs.py:347: def _update_volume_status(self):
cinder/volume/drivers/netapp/nfs.py:349: super(NetAppDirectCmodeNfsDriver, self)._update_volume_status()
cinder/volume/drivers/netapp/nfs.py:479: def _update_volume_status(self):
cinder/volume/drivers/netapp/nfs.py:481: super(NetAppDirect7modeNfsDriver, self)._update_volume_status()
cinder/volume/drivers/nexenta/volume.py:304: self._update_volume_status()
cinder/volume/drivers/nexenta/volume.py:308: def _update_volume_status(self):
cinder/volume/drivers/nfs.py:444: self._update_volume_status()
cinder/volume/drivers/nfs.py:448: def _update_volume_status(self):
cinder/volume/drivers/storwize_svc.py:1339: self._update_volume_status()
cinder/volume/drivers/storwize_svc.py:1343: def _update_volume_status(self):
cinder/volume/drivers/storwize_svc.py:1363: exception_message = (_('_update_volume_status: '
cinder/volume/drivers/storwize_svc.py:1376: exception_message = (_('_update_volume_status: '
What about all the occurrences in the locale/ directory? Should they be renamed as well?
cinder/ locale/ bg_BG/LC_ MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get system name" locale/ bg_BG/LC_ MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get storage pool data" locale/ bs/LC_MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get system name" locale/ bs/LC_MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get storage pool data" locale/ ca/LC_MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get system name" locale/ ca/LC_MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get storage pool data" locale/ cinder. pot:msgid "_update_ volume_ status: Could not get system name" locale/ cinder. pot:msgid "_update_ volume_ status: Could not get storage pool data" locale/ cs/LC_MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get system name" locale/ cs/LC_MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get storage pool data" locale/ da/LC_MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get system name" locale/ da/LC_MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get storage pool data" locale/ de/LC_MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get system name" locale/ de/LC_MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get storage pool data" locale/ en_AU/LC_ MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get system name" locale/ en_AU/LC_ MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get storage pool data" locale/ en_GB/LC_ MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get system name" locale/ en_GB/LC_ MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get storage pool data" locale/ en_US/LC_ MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get system name" locale/ en_US/LC_ MESSAGES/ cinder. po:msgstr "_update_ volume_ status: Could not get system name" locale/ en_US/LC_ MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get storage pool data" locale/ en_US/LC_ MESSAGES/ cinder. po:msgstr "_update_ volume_ status: Could not get storage pool data" locale/ es/LC_MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get system name" locale/ es/LC_MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get storage pool data" locale/ fi_FI/LC_ MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get system name" locale/ fi_FI/LC_ MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get storage pool data" locale/ fr/LC_MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get system name" locale/ fr/LC_MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get storage pool data" locale/ hr/LC_MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get system name" locale/ hr/LC_MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get storage pool data" locale/ hu/LC_MESSAGES/ cinder. po:msgid "_update_ volume_ status: Could not get system name" locale/ hu/LC_MESSAGES/ cinde.. .
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/
cinder/