Cinder

SolidFire driver should catch Connection Refused error

Bug #1195910 reported by John Griffith
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
John Griffith
Cinder 2013.2 "havana"
Grizzly
Fix Released
High
Vish Ishaya
Cinder 2013.1.3

Bug Description

When configuring the SolidFire driver if the san_ip is incorrect or not available the volume-service will crash due to an unhandled ECONNREFUSED exception.

Catch the exception and log an error instead of crashing the service.

John Griffith (john-griffith)
Changed in cinder:
importance: Undecided → High
assignee: nobody → John Griffith (john-griffith)
milestone: none → havana-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/34961

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/34961
Committed: http://github.com/openstack/cinder/commit/d596bfe6562307343858f419062756640000b0c8
Submitter: Jenkins
Branch: master

commit d596bfe6562307343858f419062756640000b0c8
Author: John Griffith <email address hidden>
Date: Fri Jun 28 15:56:46 2013 -0600

    Handle ECONNREFUSED exception in SolidFire driver.

    The SolidFire driver wasn't handling connection exceptions
    during init (capacity updates from scheduler).

    This patch add a try/except wrap around the two places
    that this is called and logs and error rather than crashing
    cinder-volume service.

    Fixes bug: 1195910

    Change-Id: I30347cc0973bbf9dbc30ea02e204560095fc75b4

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/35318

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/grizzly)

Reviewed: https://review.openstack.org/35318
Committed: http://github.com/openstack/cinder/commit/e58cac5e23f8b1dd17cffa434e1c38da95f1e533
Submitter: Jenkins
Branch: stable/grizzly

commit e58cac5e23f8b1dd17cffa434e1c38da95f1e533
Author: John Griffith <email address hidden>
Date: Fri Jun 28 15:56:46 2013 -0600

    Handle ECONNREFUSED exception in SolidFire driver.

    The SolidFire driver wasn't handling connection exceptions
    during init (capacity updates from scheduler).

    This patch add a try/except wrap around the two places
    that this is called and logs and error rather than crashing
    cinder-volume service.

    Fixes bug: 1195910

    Change-Id: I30347cc0973bbf9dbc30ea02e204560095fc75b4
    (cherry picked from commit d596bfe6562307343858f419062756640000b0c8)

tags: added: in-stable-grizzly
Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
Alan Pevec (apevec)
tags: removed: in-stable-grizzly
Thierry Carrez (ttx)
Changed in cinder:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.