SolidFire driver should catch Connection Refused error

Bug #1195910 reported by John Griffith on 2013-06-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
High
John Griffith
Grizzly
High
Vish Ishaya

Bug Description

When configuring the SolidFire driver if the san_ip is incorrect or not available the volume-service will crash due to an unhandled ECONNREFUSED exception.

Catch the exception and log an error instead of crashing the service.

Changed in cinder:
importance: Undecided → High
assignee: nobody → John Griffith (john-griffith)
milestone: none → havana-2

Fix proposed to branch: master
Review: https://review.openstack.org/34961

Changed in cinder:
status: New → In Progress

Reviewed: https://review.openstack.org/34961
Committed: http://github.com/openstack/cinder/commit/d596bfe6562307343858f419062756640000b0c8
Submitter: Jenkins
Branch: master

commit d596bfe6562307343858f419062756640000b0c8
Author: John Griffith <email address hidden>
Date: Fri Jun 28 15:56:46 2013 -0600

    Handle ECONNREFUSED exception in SolidFire driver.

    The SolidFire driver wasn't handling connection exceptions
    during init (capacity updates from scheduler).

    This patch add a try/except wrap around the two places
    that this is called and logs and error rather than crashing
    cinder-volume service.

    Fixes bug: 1195910

    Change-Id: I30347cc0973bbf9dbc30ea02e204560095fc75b4

Changed in cinder:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/35318
Committed: http://github.com/openstack/cinder/commit/e58cac5e23f8b1dd17cffa434e1c38da95f1e533
Submitter: Jenkins
Branch: stable/grizzly

commit e58cac5e23f8b1dd17cffa434e1c38da95f1e533
Author: John Griffith <email address hidden>
Date: Fri Jun 28 15:56:46 2013 -0600

    Handle ECONNREFUSED exception in SolidFire driver.

    The SolidFire driver wasn't handling connection exceptions
    during init (capacity updates from scheduler).

    This patch add a try/except wrap around the two places
    that this is called and logs and error rather than crashing
    cinder-volume service.

    Fixes bug: 1195910

    Change-Id: I30347cc0973bbf9dbc30ea02e204560095fc75b4
    (cherry picked from commit d596bfe6562307343858f419062756640000b0c8)

tags: added: in-stable-grizzly
Thierry Carrez (ttx) on 2013-07-17
Changed in cinder:
status: Fix Committed → Fix Released
Alan Pevec (apevec) on 2013-08-06
tags: removed: in-stable-grizzly
Thierry Carrez (ttx) on 2013-10-17
Changed in cinder:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers