API common CONF entries not registered locally

Bug #1194315 reported by John Griffith on 2013-06-24
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Medium
John Griffith
Manila
Medium
Valeriy Ponomaryov

Bug Description

After change: I2114d5fc45f5299c3b2011270034a3370e0ec388 we were no longer registering defaults for cinder.api.common.py settings.

Not a huge deal but the result is that you can't run individual unit tests on API files due to "undefined" CONF settings. We should register the used CONF entries in this file.

Fix proposed to branch: master
Review: https://review.openstack.org/34284

Changed in cinder:
status: Triaged → In Progress

Reviewed: https://review.openstack.org/34284
Committed: http://github.com/openstack/cinder/commit/aac4b8569af05ecfe45d41d89b84b957e9e400ff
Submitter: Jenkins
Branch: master

commit aac4b8569af05ecfe45d41d89b84b957e9e400ff
Author: John Griffith <email address hidden>
Date: Mon Jun 24 17:38:38 2013 -0600

    Register used CONF entries in cinder.api.common.py

    After change: I2114d5fc45f5299c3b2011270034a3370e0ec388 we
    were no longer registering defaults for cinder.api.common.py settings.

    The result is that you're unable to run individual unit tests like
    cinder.tests.api.test_volume_metadata.py.

    Register the needed CONF options and we're all set again.

    Fixes bug: 1194315

    Change-Id: I6df6c5ec5687c8156a9f3794cc7f04d8d28065d9

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-07-17
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in cinder:
milestone: havana-2 → 2013.2
Changed in manila:
assignee: nobody → Valeriy Ponomaryov (vponomaryov)
milestone: none → kilo-3
importance: Undecided → Medium
status: New → In Progress

Reviewed: https://review.openstack.org/156209
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=d3cfecca835fed631cca587f44b80e24362f4883
Submitter: Jenkins
Branch: master

commit d3cfecca835fed631cca587f44b80e24362f4883
Author: vponomaryov <email address hidden>
Date: Mon Feb 16 13:57:40 2015 +0200

    Move definition of couple of config opts to proper module

    Define config options 'osapi_max_limit' and 'osapi_share_base_URL' in proper
    module to be able to run module "manila.api.common" without import of
    module "manila.common.config". Without it all unit test modules that import
    "manila.api.common" fail due to not defined mentioned config opts.

    Change-Id: I725ab6cc7d777b3384bdd9095c72ecd65079e6cf
    Closes-Bug: #1194315

Changed in manila:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2015-03-19
Changed in manila:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2015-04-30
Changed in manila:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers