SolidFire _do_clone needs to account for create_from_snapshot as well as clone

Bug #1192745 reported by John Griffith on 2013-06-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
High
John Griffith
Grizzly
High
John Griffith

Bug Description

While implementing a fix for Fixes bug: 1184235 we added a type-id check against the volume reference.

Unfortunately this was implemented as a simple get of the key, but needs to be a get with a default because in the case of create volume from snapshot this key does not exist so we're broken.

Fix proposed to branch: master
Review: https://review.openstack.org/33735

Changed in cinder:
status: Triaged → In Progress

Reviewed: https://review.openstack.org/33735
Committed: http://github.com/openstack/cinder/commit/48389857d15c5cda860fa8f9914d62b148bfd17a
Submitter: Jenkins
Branch: master

commit 48389857d15c5cda860fa8f9914d62b148bfd17a
Author: John Griffith <email address hidden>
Date: Wed Jun 19 17:33:59 2013 -0600

    Modify check for volume-type-id to a get w/default

    While implementing Fix for a previous bug to enable setting
    volume type on a cloned volume and reading it's info we added
    a vref['volume_type_id'], problem is that the _do_clone method
    is shared for both clone and create from snapshot.

    In the create from snapshot case however that key doesn't exist
    in the vref (which is a snapshot object).

    This change turns this into a key.get with a default return.

    Fixes bug: 1192745

    Change-Id: I1a6d38de614f54fcaa31ea7cc4250aacc85b0796

Changed in cinder:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/35580
Committed: http://github.com/openstack/cinder/commit/318c427db4d28ef200e8d34016df6bba3e9b46ca
Submitter: Jenkins
Branch: stable/grizzly

commit 318c427db4d28ef200e8d34016df6bba3e9b46ca
Author: John Griffith <email address hidden>
Date: Wed Jun 19 17:33:59 2013 -0600

    Modify check for volume-type-id to a get w/default

    While implementing Fix for a previous bug to enable setting
    volume type on a cloned volume and reading it's info we added
    a vref['volume_type_id'], problem is that the _do_clone method
    is shared for both clone and create from snapshot.

    In the create from snapshot case however that key doesn't exist
    in the vref (which is a snapshot object).

    This change turns this into a key.get with a default return.

    Fixes bug: 1192745

    Change-Id: I1a6d38de614f54fcaa31ea7cc4250aacc85b0796
    (cherry picked from commit 48389857d15c5cda860fa8f9914d62b148bfd17a)

Thierry Carrez (ttx) on 2013-07-17
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in cinder:
milestone: havana-2 → 2013.2
Alan Pevec (apevec) on 2014-03-31
tags: removed: grizzly-backport-potential
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers