cinder terminate_connection inconsistent API

Bug #1190419 reported by Walt Boring on 2013-06-13
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Wishlist
Xiaoxi Chen

Bug Description

It seems that the Cinder base VolumeDriver's terminate_connection includes the force parameter in it's signature, but not all the driver's match that signature.

All of the driver's should match the base terminate_connection signature of

def terminate_connection(self, volume, connector, force=False, **kwargs):

Changed in cinder:
milestone: none → havana-3
Changed in cinder:
status: New → In Progress
assignee: Walt Boring (walter-boring) → xiaoxi_chen (xiaoxi-chen)
Changed in cinder:
importance: Low → Wishlist

Reviewed: https://review.openstack.org/34070
Committed: http://github.com/openstack/cinder/commit/f76d1ee4dd812f56988f4886f183fa7a837cc254
Submitter: Jenkins
Branch: master

commit f76d1ee4dd812f56988f4886f183fa7a837cc254
Author: xiaoxi_chen <email address hidden>
Date: Tue Jul 9 10:18:30 2013 +0800

    Consist terminate_connection function signature

    Clean up the "force=False" in function signature for terminate_connection
    since it already accept **kwargs.

    Thus make all function signature for terminate_connection consist to
        def terminate_connection(self, volume, connector, **kwargs)

    Fixes: bug #1190419
    Change-Id: I8765cb8f2aa3cfbb49ff57ae034b148aee35a8c4

Changed in cinder:
status: In Progress → Fix Committed
Changed in cinder:
milestone: havana-3 → havana-2
Thierry Carrez (ttx) on 2013-07-17
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in cinder:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers