NFS not finding shares to use

[Joshua Harlow]

It appears there is a problem with NFS share calculation.

Some outputs from the corresponding section.

10.88.175.174:/var/nfs _find_share /usr/lib/python2.6/site-packages/cinder/volume/drivers/nfs.py:353
total_size = 105689645056.0 _find_share /usr/lib/python2.6/site-packages/cinder/volume/drivers/nfs.py:354
total_available = 97756643328.0 _find_share /usr/lib/python2.6/site-packages/cinder/volume/drivers/nfs.py:355
total_allocated = 4096.0 _find_share /usr/lib/python2.6/site-packages/cinder/volume/drivers/nfs.py:356
used = 0.0750594036322 _find_share /usr/lib/python2.6/site-packages/cinder/volume/drivers/nfs.py:358
oversub_ratio 1.0
used_ratio 0.95
Requested 5368709120

Error that occurs.

2013-06-11 23:46:52.200 31656 DEBUG cinder.volume.drivers.nfs [req-07b4a6b6-c63d-40e3-b51b-fdae9415c854 65a550087e0142179b6fef8fa60f65de 22b050a7c3c24ce6affee2abc7b63d7d] 10.88.175.174:/var/nfs is above nfs_oversub_ratio _find_share /usr/lib/python2.6/site-packages/cinder/volume/drivers/nfs.py:374

It appears the logic around the following is incorrect.

(total_allocated * oversub_ratio) < requested_volume_size

if oversub_ratio >= 1.0:
    # NOTE(morganfainberg): If we are setup for oversubscription
    # we need to calculate the apparent available space instead
    # of just using the _actual_ available space.
    if (total_allocated * oversub_ratio) < requested_volume_size:
        LOG.debug(_('%s is above nfs_oversub_ratio'), nfs_share)
        continue

I am not quite sure how 'total_allocated' is connected to the apparent available space. Thats probably not right.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/32664

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/32664
Committed: http://github.com/openstack/cinder/commit/05f409e747477a12bc701d304bc6dabe6939a3a4
Submitter: Jenkins
Branch: master

commit 05f409e747477a12bc701d304bc6dabe6939a3a4
Author: Joshua Harlow <email address hidden>
Date: Tue Jun 11 17:50:37 2013 -0700

    Fix the after subscription size checks.

    It seems like the calculation was incorrect previously.

    Fixes bug: #1190094

    Change-Id: Iaec3c2ece6fc80e6bb87fde0a408608825212b49