Pyflakes error in EMC driver

Bug #1188619 reported by Dirk Mueller on 2013-06-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
High
Dirk Mueller
Grizzly
High
Dirk Mueller

Bug Description

Running Pyflakes on cinder/volume/drivers/emc/emc_smis_common.py gives:

cinder/volume/drivers/emc/emc_smis_common.py:1317: undefined name 'conn'

This is because there is a typo in the code, it should have been self.conn.Associators instead. The error is not triggered by the testsuite because the whole function is unused.

We can either remove the function alltogether or fix the typo.

Changed in cinder:
assignee: nobody → Dirk Mueller (dmllr)
status: New → In Progress

Reviewed: https://review.openstack.org/31378
Committed: http://github.com/openstack/cinder/commit/2384c4908c284aab4b4da53b4e12f1073052e8ab
Submitter: Jenkins
Branch: master

commit 2384c4908c284aab4b4da53b4e12f1073052e8ab
Author: Dirk Mueller <email address hidden>
Date: Sat Jun 1 14:48:03 2013 +0200

    Fix 'undefined symbol conn' error

    Use self.conn, not conn.

    Fixes LP Bug #1188619

    Change-Id: Idbd62016fda4cafb6df953ca57af94d56edd3918

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-07-17
Changed in cinder:
milestone: none → havana-2
status: Fix Committed → Fix Released
Changed in cinder:
importance: Undecided → High

Reviewed: https://review.openstack.org/31385
Committed: http://github.com/openstack/cinder/commit/d443987768c8ccc1820b8df083f4e7d730119896
Submitter: Jenkins
Branch: stable/grizzly

commit d443987768c8ccc1820b8df083f4e7d730119896
Author: Dirk Mueller <email address hidden>
Date: Sat Jun 1 14:48:03 2013 +0200

    Fix 'undefined symbol conn' error

    Use self.conn, not conn.

    Fixes LP Bug #1188619

    Change-Id: Idbd62016fda4cafb6df953ca57af94d56edd3918

Thierry Carrez (ttx) on 2013-10-17
Changed in cinder:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers