tgt-admin exceptions aren't logging error response

Bug #1186991 reported by John Griffith on 2013-06-03
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
High
Avishay Traeger

Bug Description

We're catching exceptions from calls to tgt-admin and handling them well enough, however there are a number of places where we're not providing the error response info (from the tgt-admin call) anywhere in the logs.

This makes debug a bit of a guessing game. We should add the error response from the ProcessExecution exception to the log output.

Changed in cinder:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Avishay Traeger (avishay-il)
milestone: none → havana-2
tags: added: grizzly-backport-potential

Fix proposed to branch: master
Review: https://review.openstack.org/31618

Changed in cinder:
status: Triaged → In Progress

Reviewed: https://review.openstack.org/31618
Committed: http://github.com/openstack/cinder/commit/f7730d31df65ec166b2bdb6667162dc22f7d4fd6
Submitter: Jenkins
Branch: master

commit f7730d31df65ec166b2bdb6667162dc22f7d4fd6
Author: Avishay Traeger <email address hidden>
Date: Tue Jun 4 11:46:20 2013 +0300

    Log iSCSI target output on error.

    Add the command output on error to aid in debugging.

    Change-Id: Ib505eaeba7f1ca0e54e99dec8ebbbf71df3e5a51
    Fixes: bug 1186991

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-07-17
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in cinder:
milestone: havana-2 → 2013.2
Alan Pevec (apevec) on 2014-03-31
tags: removed: grizzly-backport-potential
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers