Unable to modify volume-type/QoS on cloned SolidFire volume

Bug #1184235 reported by John Griffith on 2013-05-25
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
High
John Griffith
Grizzly
High
John Griffith

Bug Description

The SolidFire driver was not honoring the new volume type that were passed in on a clone operation. This means that it always inherrited QoS from the parent volume regardless if the user requested a different setting or not.

Fix proposed to branch: master
Review: https://review.openstack.org/30548

Changed in cinder:
assignee: nobody → John Griffith (john-griffith)
status: New → In Progress
Changed in cinder:
importance: Undecided → High
tags: added: grizzly-backport-potential
removed: folsom-backport-potential
Changed in cinder:
milestone: none → havana-1
Mike Perez (thingee) on 2013-05-29
Changed in cinder:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/30548
Committed: http://github.com/openstack/cinder/commit/37fa1ef51ef389ed7ac0affb1dd59ba680ca52df
Submitter: Jenkins
Branch: master

commit 37fa1ef51ef389ed7ac0affb1dd59ba680ca52df
Author: John Griffith <email address hidden>
Date: Sat May 25 17:52:30 2013 -0600

    Update cloned volumes QoS settings.

    The SolidFire device inherits all settings (including QoS) from
    the parent on a clone. This meant that although we were expecting
    QoS to be updated when a clone was issued with a different Volume
    Type than the parent volume it was never acted upon.

    This change fixes that bug by simply adding the *new* qos settings
    to the ModifyVolume call after cloning.

    Fixes bug: 1184235

    Change-Id: I81786a07312027d543b9f06e54dfbf57e6085bc9

Thierry Carrez (ttx) on 2013-05-29
Changed in cinder:
status: Fix Committed → Fix Released

Reviewed: https://review.openstack.org/31084
Committed: http://github.com/openstack/cinder/commit/46f1e0a129b8165a21a23e8e45c9021680f2382f
Submitter: Jenkins
Branch: stable/grizzly

commit 46f1e0a129b8165a21a23e8e45c9021680f2382f
Author: John Griffith <email address hidden>
Date: Sat May 25 17:52:30 2013 -0600

    Update cloned volumes QoS settings.

    The SolidFire device inherits all settings (including QoS) from
    the parent on a clone. This meant that although we were expecting
    QoS to be updated when a clone was issued with a different Volume
    Type than the parent volume it was never acted upon.

    This change fixes that bug by simply adding the *new* qos settings
    to the ModifyVolume call after cloning.

    Fixes bug: 1184235

    Change-Id: I81786a07312027d543b9f06e54dfbf57e6085bc9
    (cherry picked from commit 37fa1ef51ef389ed7ac0affb1dd59ba680ca52df)

tags: removed: grizzly-backport-potential
Thierry Carrez (ttx) on 2013-10-17
Changed in cinder:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers