3par drivers are double synchronizing a number of methods

[Kurt Martin]

There are many cases where the 3par drivers(FC and iSCSI) are double locking, e.g. we lock in the individual driver and in ‘common’. We can remove all the locks in ‘common’ except the one on ‘create_cloned_volume’. The methods ’_get_volume_state’ and ‘_copy_volume’ are only called in ‘create_cloned_volume’, so those locks can be removed as well. All the other methods in ‘common’ are only called by the driver which provide the lock, except ‘create_volume’ which is also called by ‘create_cloned_volume’.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/28112

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/28112
Committed: http://github.com/openstack/cinder/commit/0ee20a008746a83069c5465b74866f6e41731752
Submitter: Jenkins
Branch: master

commit 0ee20a008746a83069c5465b74866f6e41731752
Author: Kurt Martin <email address hidden>
Date: Wed Oct 31 17:20:29 2012 -0700

    Fixes 3par driver methods that were double locking

    There were many cases where the 3par drivers(FC and iSCSI) were double
    locking, e.g. we were locking in the individual driver and in ‘common’.
    This patch set removes all the locks in ‘common’ except the one on
    ‘create_cloned_volume’.

    The methods ’_get_volume_state’ and ‘_copy_volume’ are only called in
    ‘create_cloned_volume’, so those locks were removed as well. All the other
    methods in ‘common’ are only called by the driver which provide the lock,
    except ‘create_volume’ which is also called by ‘create_cloned_volume’.

    Change-Id: I660fbd04824bd2837e06480c8298ea5a709fc82a
    Fixes: bug 1175791

[Walt Boring (walter-boring)]

Grizzly no longer supported