3par drivers are double synchronizing a number of methods

Bug #1175791 reported by Kurt Martin on 2013-05-02
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Undecided
Kurt Martin
Grizzly
Undecided
Kurt Martin

Bug Description

There are many cases where the 3par drivers(FC and iSCSI) are double locking, e.g. we lock in the individual driver and in ‘common’. We can remove all the locks in ‘common’ except the one on ‘create_cloned_volume’. The methods ’_get_volume_state’ and ‘_copy_volume’ are only called in ‘create_cloned_volume’, so those locks can be removed as well. All the other methods in ‘common’ are only called by the driver which provide the lock, except ‘create_volume’ which is also called by ‘create_cloned_volume’.

Changed in cinder:
assignee: nobody → Kurt Martin (kurt-f-martin)
tags: added: drivers
Changed in cinder:
status: New → Confirmed
summary: - 3par driver are double synchronizing a number of methods
+ 3par drivers are double synchronizing a number of methods

Fix proposed to branch: master
Review: https://review.openstack.org/28112

Changed in cinder:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/28112
Committed: http://github.com/openstack/cinder/commit/0ee20a008746a83069c5465b74866f6e41731752
Submitter: Jenkins
Branch: master

commit 0ee20a008746a83069c5465b74866f6e41731752
Author: Kurt Martin <email address hidden>
Date: Wed Oct 31 17:20:29 2012 -0700

    Fixes 3par driver methods that were double locking

    There were many cases where the 3par drivers(FC and iSCSI) were double
    locking, e.g. we were locking in the individual driver and in ‘common’.
    This patch set removes all the locks in ‘common’ except the one on
    ‘create_cloned_volume’.

    The methods ’_get_volume_state’ and ‘_copy_volume’ are only called in
    ‘create_cloned_volume’, so those locks were removed as well. All the other
    methods in ‘common’ are only called by the driver which provide the lock,
    except ‘create_volume’ which is also called by ‘create_cloned_volume’.

    Change-Id: I660fbd04824bd2837e06480c8298ea5a709fc82a
    Fixes: bug 1175791

Changed in cinder:
status: In Progress → Fix Committed
tags: added: grizzly-backport-potential
Thierry Carrez (ttx) on 2013-05-29
Changed in cinder:
milestone: none → havana-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in cinder:
milestone: havana-1 → 2013.2
tags: removed: grizzly-backport-potential
Walt Boring (walter-boring) wrote :

Grizzly no longer supported

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers