cinder mounting nfs and glusterfs volume will fail silently when cinder is installed in machines with other language than english

[mouadino]

Let's dive in the code directly shall we:

    def _path_exists(self, path):
         """Check for existence of given path."""
         try:
             self._execute('stat', path, run_as_root=True)
             return True
         except exception.ProcessExecutionError as exc:
             if 'No such file or directory' in exc.stderr:
                 return False
             else:
                raise

This method is part of RemoteFsDriver class (in /volume/drivers/nfs.py ) and this is where the bug is, to check that a path exist it execute the command "stat" and than lookup the sentence "No such file or directory" in stderr, so clearly this will fail big time if host machine language is different than english.

But it surely there is no easy way as far as i know to test if a path exist as another system user (root), but the good news is that we don't need to, actually we can remove this method, and everything will work fine, patch coming soon for more detail on what i mean :)

Cheers,

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/27499

[Avishay Traeger (avishay-il)]

I am out of the office until 05/12/2013.

For technical issues regarding the Storwize/SVC Cinder driver, please
contact: Jie Ping Wu <email address hidden>, Li Min Liu <email address hidden>,
Ronen Kat <email address hidden>
For all other issue, please contact my manager, Dalit Naor
<email address hidden>

Note: This is an automated response to your message "[Bug 1172777] [NEW]
cinder mounting nfs and glusterfs volume will fail silently when cinder
is installed in machines with other language than english" sent on
25/04/2013 19:09:36.

This is the only notification you will receive while this person is away.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/27499
Committed: http://github.com/openstack/cinder/commit/51218b2b32edbc79e89195d58b7b7e330a6d1486
Submitter: Jenkins
Branch: master

commit 51218b2b32edbc79e89195d58b7b7e330a6d1486
Author: mouad benchchaoui <email address hidden>
Date: Thu Apr 25 18:12:09 2013 +0200

    Remove _path_exists method.

    This method is buggy because it works only on host machine with english language, and
    apparently this method is also useless because we don't need to check if a path exist if
    we can use command option -p for "mkdir" command and option -f for "rm" command.

    bug: LP#1172777
    Change-Id: I418b32772ca97b42e1a43275a7abec9f96688607