cinder backup db call and read_deleted="yes"?

Bug #1169857 reported by Michael Kerrin on 2013-04-17
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
High
Michael Kerrin
Grizzly
High
John Griffith

Bug Description

Cinder backup list calls backup_get_all_by_project in cinder/db/sqlalchemy/api.py

This just returns model_query(context, models.Backup, read_deleted="yes").all()

Is the read_deleted argument correct here?

read_deleted seems to be used in a bunch of the backup db calls, not just that one, consider removing in all of them

Fix proposed to branch: master
Review: https://review.openstack.org/27072

Changed in cinder:
assignee: nobody → Michael Kerrin (michael-kerrin-w)
status: New → In Progress
tags: added: grizzly-backport-potential
Changed in cinder:
importance: Undecided → High
milestone: none → havana-1

Reviewed: https://review.openstack.org/27072
Committed: http://github.com/openstack/cinder/commit/a4ba17b668bd893d50fd4f3a5453da89966a77e3
Submitter: Jenkins
Branch: master

commit a4ba17b668bd893d50fd4f3a5453da89966a77e3
Author: Michael Kerrin <email address hidden>
Date: Wed Apr 17 15:36:28 2013 +0000

    Deleting a backup removed the backup record from database

    Instead we should be marking the backup as deleted so that we have an audit
    of all the backups. Backups are now marked deleted in the way that volumes
    are.

    Fixes bug: 1169943
    Fixes bug: 1169857

    Change-Id: I52c603be138c0f1d6d411d167977041255ac9053

Changed in cinder:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/28205
Committed: http://github.com/openstack/cinder/commit/2e3c1cd77b3d523c48ff4a086cccf68fd11c4c19
Submitter: Jenkins
Branch: stable/grizzly

commit 2e3c1cd77b3d523c48ff4a086cccf68fd11c4c19
Author: Michael Kerrin <email address hidden>
Date: Wed Apr 17 15:36:28 2013 +0000

    Dont delete backup record from database

    Instead we should be marking the backup as deleted so that we have an audit
    of all the backups. Backups are now marked deleted in the way that volumes
    are.

    Fixes bug: 1169943
    Fixes bug: 1169857

    Change-Id: I52c603be138c0f1d6d411d167977041255ac9053
    (cherry picked from commit a4ba17b668bd893d50fd4f3a5453da89966a77e3)

Alan Pevec (apevec) on 2013-05-05
tags: removed: grizzly-backport-potential
Thierry Carrez (ttx) on 2013-05-29
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in cinder:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers