ThinLVM driver fails due to get_stats

Bug #1166572 reported by John Griffith on 2013-04-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
High
John Griffith
Grizzly
High
John Griffith

Bug Description

The ThinLVM driver inherits get_stats info from the standard LVM driver. This unfortunately won't work because reading used capacity from a Thin provisioned LV is not done the same as with a regular LV obviously.

The ThinLVM driver should return it's own capabilities, including using the "infinite" designation for capacity and also the fact that it's thin provisioned :)

Changed in cinder:
status: New → Triaged
milestone: none → havana-1
tags: added: grizzly-backport-potential

Fix proposed to branch: master
Review: https://review.openstack.org/26896

Changed in cinder:
status: Triaged → In Progress

Reviewed: https://review.openstack.org/26896
Committed: http://github.com/openstack/cinder/commit/a95a2149a5ba805451a6d961b792ccd5b9984bea
Submitter: Jenkins
Branch: master

commit a95a2149a5ba805451a6d961b792ccd5b9984bea
Author: John Griffith <email address hidden>
Date: Thu Apr 11 20:05:01 2013 -0600

    Add capabilities reporting to ThinLVM driver

    ThinLVM driver was missing the newly required capabilities reporting
    and inheritance from the parent LVM driver doesn't work because the
    capacity reporting methods between regular LVM and Thin LVM are not
    compatible.

    This patch add the basic requirements needed in the capabilities reporting
    to make it usable by the filter scheduler.

    Fixes bug: 1166572

    Change-Id: I471dcc31d07516e71bcd2d3ae03e0405e0594697

Changed in cinder:
status: In Progress → Fix Committed
Changed in cinder:
milestone: havana-1 → 2013.1.1
status: Fix Committed → In Progress
milestone: 2013.1.1 → havana-1
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/28199
Committed: http://github.com/openstack/cinder/commit/6221a0e279c795270d03fb03dc2c848fd6f44056
Submitter: Jenkins
Branch: stable/grizzly

commit 6221a0e279c795270d03fb03dc2c848fd6f44056
Author: John Griffith <email address hidden>
Date: Thu Apr 11 20:05:01 2013 -0600

    Add capabilities reporting to ThinLVM driver

    ThinLVM driver was missing the newly required capabilities reporting
    and inheritance from the parent LVM driver doesn't work because the
    capacity reporting methods between regular LVM and Thin LVM are not
    compatible.

    This patch add the basic requirements needed in the capabilities reporting
    to make it usable by the filter scheduler.

    Fixes bug: 1166572

    Change-Id: I471dcc31d07516e71bcd2d3ae03e0405e0594697
    (cherry picked from commit a95a2149a5ba805451a6d961b792ccd5b9984bea)

tags: added: in-stable-grizzly
removed: grizzly-backport-potential
Alan Pevec (apevec) on 2013-05-05
tags: removed: in-stable-grizzly
Thierry Carrez (ttx) on 2013-05-29
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in cinder:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers