storwize svc driver needs to avoid SVC CLI shortcut

Bug #1163964 reported by Alan Jiang on 2013-04-03
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
High
Avishay Traeger
Grizzly
High
Avishay Traeger

Bug Description

For SVC storwize driver, the SVC cli is invoked directly by using cli shortcut instead of a svcinfo or svctask wrapper.
The shortcut is h/w model dependent. The safer way to invoke svc CLI is to wrap SVC cli with svcinfo and svctask command and handle the SVC error code if the command is not supported.

svcinfo -? and svctask -? can dump all the supported cli on a given SVC.

For example, on V3700, lslicense is not supported, and some older SVC f/w version doesn't support lssystem

Those SVC CLI error will cause storwize_svc to throw exception and break cinder when managing some SVC model.

Avishay Traeger (avishay-il) wrote :

This bug is related to bug 1163754, which is one instance of a command that is not supported in all firmware versions. They can be fixed together.

Changed in cinder:
status: New → Confirmed
tags: added: drivers grizzly-backport-potential storwize-svc
Changed in cinder:
importance: Undecided → High
assignee: nobody → Avishay Traeger (avishay-il)

Fix proposed to branch: master
Review: https://review.openstack.org/26587

Changed in cinder:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/26587
Committed: http://github.com/openstack/cinder/commit/f38f943899ea95fe237be1d096ceafd35b57a843
Submitter: Jenkins
Branch: master

commit f38f943899ea95fe237be1d096ceafd35b57a843
Author: Avishay Traeger <email address hidden>
Date: Wed Apr 10 11:24:45 2013 +0300

    Fix incompatible Storwize/SVC commands.

    Inconsistencies in the command line syntax between Storwize/SVC
    models and firmware versions caused driver failures. This patch
    makes commands compatible to fix driver crashes on the V3700 and
    controllers with firmware version 6.3.

    Change-Id: I51d5b97afa5419cdbf488f9e4e4597d22bb22f20
    Fixes: bug 1163754
    Fixed: bug 1163964

Changed in cinder:
status: In Progress → Fix Committed
tags: removed: drivers grizzly-backport-potential
Thierry Carrez (ttx) on 2013-05-29
Changed in cinder:
milestone: none → havana-1
status: Fix Committed → Fix Released

Reviewed: https://review.openstack.org/26815
Committed: http://github.com/openstack/cinder/commit/c27f0747965be98b33d4a18fe78dfeaf5a0c1cc6
Submitter: Jenkins
Branch: stable/grizzly

commit c27f0747965be98b33d4a18fe78dfeaf5a0c1cc6
Author: Avishay Traeger <email address hidden>
Date: Fri May 31 07:55:02 2013 +0300

    Fix incompatible Storwize/SVC commands.

    Inconsistencies in the command line syntax between Storwize/SVC
    models and firmware versions caused driver failures. This patch
    makes commands compatible to fix driver crashes on the V3700 and
    controllers with firmware version 6.3.

    Cherry-picked from f38f943899ea95fe237be1d096ceafd35b57a843

    Change-Id: I51d5b97afa5419cdbf488f9e4e4597d22bb22f20
    Fixes: bug 1163754
    Fixed: bug 1163964

tags: added: in-stable-grizzly
Alan Pevec (apevec) on 2013-08-06
tags: removed: in-stable-grizzly
Thierry Carrez (ttx) on 2013-10-17
Changed in cinder:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers